If you aren't allowed to create / edit a page in a group, don't show the "Add" and "Copy" buttons

Bug #1683224 reported by Kristina Hoeppner on 2017-04-17
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
15.10
Undecided
Unassigned
16.04
High
Unassigned
16.10
High
Unassigned
17.04
High
Unassigned
17.10
High
Unassigned

Bug Description

Mahara 17.04RC1 (but also previous versions of Mahara)

When you are in a group but are not allowed to add or edit a page, you still see the "Add" and "Copy" buttons. When you click a button, only then will you get the information that you can't actually add or copy a page.

For improved usability, these two buttons shouldn't be displayed on "Pages and collections" if you aren't allowed to add or copy portfolios.

Won't fix for 15.10 as it's going out of support in April 2017.

Robert Lyon (robertl-9) wrote :

This only seems to be a problem with 17.04+

Before that there were 2 different templates used for group page list depending on if you had edit permissions or not.

But now there is only one template and so needed to add a can edit check for displaying the buttons

Reviewed: https://reviews.mahara.org/7662
Committed: https://git.mahara.org/mahara/mahara/commit/ec0480eda755dafec8d31a4adce0a2a99aa07c34
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ec0480eda755dafec8d31a4adce0a2a99aa07c34
Author: Robert Lyon <email address hidden>
Date: Thu Apr 20 21:15:06 2017 +1200

Bug 1683224: Hide 'add/copy' buttons on group pages/collections

If the user is a member without editing rights

behatnotneeded

Change-Id: Ibf33a1a87be5853ba543008e9969168eb3fb125a
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/7689
Committed: https://git.mahara.org/mahara/mahara/commit/6388aaa61f9a4e2724df1bb46306e71b18ae06b2
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 6388aaa61f9a4e2724df1bb46306e71b18ae06b2
Author: Robert Lyon <email address hidden>
Date: Thu Apr 20 21:15:06 2017 +1200

Bug 1683224: Hide 'add/copy' buttons on group pages/collections

If the user is a member without editing rights

behatnotneeded

Change-Id: Ibf33a1a87be5853ba543008e9969168eb3fb125a
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit ec0480eda755dafec8d31a4adce0a2a99aa07c34)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers