Image block showing 'http://' as part of description

Bug #1681974 reported by Robert Lyon on 2017-04-12
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
15.10
High
Unassigned
17.04
High
Robert Lyon
17.10
High
Unassigned

Bug Description

The image block in master showing the image title when you say
"Show description" and why is it displayed as http://image.png ?

The description has always been the "Description" that you need to enter
manually and if the image doesn't have a description, it is not shown.

Robert Lyon (robertl-9) on 2017-04-12
Changed in mahara:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 17.04.0
Robert Lyon (robertl-9) on 2017-04-12
summary: - Image block showing title as part of description
+ Image block showing 'http://' as part of description

Reviewed: https://reviews.mahara.org/7626
Committed: https://git.mahara.org/mahara/mahara/commit/c75de1cd67ec7dc3bff30dd58b03d872ea9afa09
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c75de1cd67ec7dc3bff30dd58b03d872ea9afa09
Author: Robert Lyon <email address hidden>
Date: Wed Apr 12 13:09:28 2017 +1200

Bug 1681974: Image description showing 'http://' in the text

Reverting the code change for Bug 1579145 where it tries to guess what
is a URL

behatnotneeded

Change-Id: I96440ce8eafa7fbd3ac6100b3a0ef1e3cd22d137
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/7681
Committed: https://git.mahara.org/mahara/mahara/commit/c7e938a8dfc76314ff6fc0b626a222ae4a693fbf
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit c7e938a8dfc76314ff6fc0b626a222ae4a693fbf
Author: Robert Lyon <email address hidden>
Date: Wed Apr 12 13:09:28 2017 +1200

Bug 1681974: Image description showing 'http://' in the text

Reverting the code change for Bug 1579145 where it tries to guess what
is a URL

behatnotneeded

Change-Id: I96440ce8eafa7fbd3ac6100b3a0ef1e3cd22d137
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c75de1cd67ec7dc3bff30dd58b03d872ea9afa09)

Robin Leung (robin-leung) wrote :

Hi Robert,
Does this patch also work backward with 16.10?

Robert Lyon (robertl-9) wrote :

Hi Robin,

The patch will not cleanly merge back with 16.10 because in 17.04 we have both 'raw' and 'raw_old' themes.

I'll make a patch for 16.10 soon

Cheers

Robert

Robert Lyon (robertl-9) wrote :

Ok for some reason the patch that this one fixes was not backported to 16.10 - so this doesn't need to be backported to 16.10 either.

It was however backported to 15.10 so I've added the fix for 15.10 branch too.

no longer affects: mahara/16.10

It's a new feature that was backported to 15.10 accidentally. In order no to put more new features into 16.04 and 16.10, we'll not backport this to the supported branches of 16.04 and 16.10, but can give you a patch for your instance, Robin.

Reviewed: https://reviews.mahara.org/7691
Committed: https://git.mahara.org/mahara/mahara/commit/14f229e72db129b108eb270d6b2b5ece3a0f2dfb
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 14f229e72db129b108eb270d6b2b5ece3a0f2dfb
Author: Robert Lyon <email address hidden>
Date: Wed Apr 26 10:05:16 2017 +1200

Bug 1681974: Image description showing 'http://' in the text

Reverting the code change for Bug 1579145 where it tries to guess what
is a URL

behatnotneeded

Change-Id: I96440ce8eafa7fbd3ac6100b3a0ef1e3cd22d137
Signed-off-by: Robert Lyon <email address hidden>

Robin Leung (robin-leung) wrote :

A patch for 16.10.2 would be much appreciated, Kristina.
I just saw that 16.10.3 came out today, so we might be doing that minor upgrade. But I don't think the patch will make any difference between the .2 and .3 version difference, correct?

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers