Copying a collection displays a warning message

[Niranjan]

Tested on
Site: https://master-mahara.catalystdemo.net.nz
Browser: Chrome/FF/Safari 10.0.3
Device: Desktop/MacBook Pro

Steps to reproduce:

1)Navigate to Portfolio>Pages and collections
2)Click on Copy button
3) Click on Copy collection button

Actual Result on desktop : A warning message is desplayed , please find it below

[WAR] e7 (lib/adodb/adodb-exceptions.inc.php:45) Array to string conversion

Call stack (most recent first):
log_message("Array to string conversion", 8, true, true, "/home/niranjanbandi/code/mahara/htdocs/lib/adodb/a...", 45) at /home/niranjanbandi/code/mahara/htdocs/lib/errors.php:521
error(8, "Array to string conversion", "/home/niranjanbandi/code/mahara/htdocs/lib/adodb/a...", 45, array(size 7)) at /home/niranjanbandi/code/mahara/htdocs/lib/adodb/adodb-exceptions.inc.php:45
ADODB_Exception->__construct("postgres8", "adodb_throw", -1, "ERROR: null value in column "submittedstatus" vio...", "UPDATE "collection" SET "name" = ?, "description" ...", array(size 14), object(ADODB_postgres8)) at /home/niranjanbandi/code/mahara/htdocs/lib/adodb/adodb-exceptions.inc.php:80
adodb_throw("postgres8", "adodb_throw", -1, "ERROR: null value in column "submittedstatus" vio...", "UPDATE "collection" SET "name" = ?, "description" ...", array(size 14), object(ADODB_postgres8)) at /home/niranjanbandi/code/mahara/htdocs/lib/adodb/adodb.inc.php:313
ADODB_TransMonitor("postgres8", "adodb_throw", -1, "ERROR: null value in column "submittedstatus" vio...", "UPDATE "collection" SET "name" = ?, "description" ...", array(size 14), object(ADODB_postgres8)) at /home/niranjanbandi/code/mahara/htdocs/lib/adodb/adodb.inc.php:1264
ADOConnection->_Execute("UPDATE "collection" SET "name" = ?, "description" ...", array(size 14)) at /home/niranjanbandi/code/mahara/htdocs/lib/adodb/adodb.inc.php:1224
ADOConnection->Execute("UPDATE "collection" SET "name" = ?, "description" ...", array(size 14)) at /home/niranjanbandi/code/mahara/htdocs/lib/dml.php:1304
update_record("collection", object(stdClass), array(size 1)) at /home/niranjanbandi/code/mahara/htdocs/lib/collection.php:171
Collection->commit() at /home/niranjanbandi/code/mahara/htdocs/lib/collection.php:868
Collection->add_views(array(size 2)) at /home/niranjanbandi/code/mahara/htdocs/lib/collection.php:311
Collection::create_from_template(array(size 5), 5) at /home/niranjanbandi/code/mahara/htdocs/lib/view.php:6662
createview_submit(object(Pieform), array(size 5)) at /home/niranjanbandi/code/mahara/htdocs/lib/pieforms/pieform.php:543
Pieform->__construct(array(size 8)) at /home/niranjanbandi/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at /home/niranjanbandi/code/mahara/htdocs/lib/mahara.php:4814
pieform(array(size 8)) at /home/niranjanbandi/code/mahara/htdocs/view/choosetemplate.php:30

[WAR] e7 (lib/errors.php:859) Failed to get a recordset: postgres8 error: [-1: ERROR: null value in column "submittedstatus" violates not-null constraint
DETAIL: Failing row contains (8, 1, 2017-04-10 11:16:53, 2017-04-10 11:16:53, collect5555 v.2, sagdsgsag, 1, null, null, null, null, null, null, null).] in adodb_throw(UPDATE "collection" SET "name" = ?, "description" = ?, "owner" = ?, "group" = ?, "institution" = ?, "mtime" = ?, "ctime" = ?, "navigation" = ?, "submittedgroup" = ?, "submittedhost" = ?, "submittedtime" = ?, "submittedstatus" = ?, "framework" = ? WHERE "id" = ?, Array)Command was: UPDATE "collection" SET "name" = ?, "description" = ?, "owner" = ?, "group" = ?, "institution" = ?, "mtime" = ?, "ctime" = ?, "navigation" = ?, "submittedgroup" = ?, "submittedhost" = ?, "submittedtime" = ?, "submittedstatus" = ?, "framework" = ? WHERE "id" = ? and values was (0:collect5555v.2,1:sagdsgsag,2:1,3:,4:,5:2017-04-1011:16:53,6:2017-04-1011:16:53,7:1,8:,9:,10:,11:,12:,13:8)

Call stack (most recent first):
log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, true, true) at /home/niranjanbandi/code/mahara/htdocs/lib/errors.php:95
log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at /home/niranjanbandi/code/mahara/htdocs/lib/errors.php:859
SQLException->__construct("Failed to get a recordset: postgres8 error: [-1: E...") at /home/niranjanbandi/code/mahara/htdocs/lib/dml.php:1308
update_record("collection", object(stdClass), array(size 1)) at /home/niranjanbandi/code/mahara/htdocs/lib/collection.php:171
Collection->commit() at /home/niranjanbandi/code/mahara/htdocs/lib/collection.php:868
Collection->add_views(array(size 2)) at /home/niranjanbandi/code/mahara/htdocs/lib/collection.php:311
Collection::create_from_template(array(size 5), 5) at /home/niranjanbandi/code/mahara/htdocs/lib/view.php:6662
createview_submit(object(Pieform), array(size 5)) at /home/niranjanbandi/code/mahara/htdocs/lib/pieforms/pieform.php:543
Pieform->__construct(array(size 8)) at /home/niranjanbandi/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at /home/niranjanbandi/code/mahara/htdocs/lib/mahara.php:4814
pieform(array(size 8)) at /home/niranjanbandi/code/mahara/htdocs/view/choosetemplate.php:30

[WAR] e7 (lib/dml.php:1308) Failed to get a recordset: postgres8 error: [-1: ERROR: null value in column "submittedstatus" violates not-null constraint
DETAIL: Failing row contains (8, 1, 2017-04-10 11:16:53, 2017-04-10 11:16:53, collect5555 v.2, sagdsgsag, 1, null, null, null, null, null, null, null).] in adodb_throw(UPDATE "collection" SET "name" = ?, "description" = ?, "owner" = ?, "group" = ?, "institution" = ?, "mtime" = ?, "ctime" = ?, "navigation" = ?, "submittedgroup" = ?, "submittedhost" = ?, "submittedtime" = ?, "submittedstatus" = ?, "framework" = ? WHERE "id" = ?, Array)Command was: UPDATE "collection" SET "name" = ?, "description" = ?, "owner" = ?, "group" = ?, "institution" = ?, "mtime" = ?, "ctime" = ?, "navigation" = ?, "submittedgroup" = ?, "submittedhost" = ?, "submittedtime" = ?, "submittedstatus" = ?, "framework" = ? WHERE "id" = ? and values was (0:collect5555v.2,1:sagdsgsag,2:1,3:,4:,5:2017-04-1011:16:53,6:2017-04-1011:16:53,7:1,8:,9:,10:,11:,12:,13:8)

Call stack (most recent first):
update_record("collection", object(stdClass), array(size 1)) at /home/niranjanbandi/code/mahara/htdocs/lib/collection.php:171
Collection->commit() at /home/niranjanbandi/code/mahara/htdocs/lib/collection.php:868
Collection->add_views(array(size 2)) at /home/niranjanbandi/code/mahara/htdocs/lib/collection.php:311
Collection::create_from_template(array(size 5), 5) at /home/niranjanbandi/code/mahara/htdocs/lib/view.php:6662
createview_submit(object(Pieform), array(size 5)) at /home/niranjanbandi/code/mahara/htdocs/lib/pieforms/pieform.php:543
Pieform->__construct(array(size 8)) at /home/niranjanbandi/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at /home/niranjanbandi/code/mahara/htdocs/lib/mahara.php:4814
pieform(array(size 8)) at /home/niranjanbandi/code/mahara/htdocs/view/choosetemplate.php:30

And on safari I get the follwing message

Mahara: Site unavailable
A nonrecoverable error occurred. This probably means you have encountered a bug in the system

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/7610

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7610
Committed: https://git.mahara.org/mahara/mahara/commit/c156c8fd5a6613ca0cd457fdcb9fa2483de22d3a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c156c8fd5a6613ca0cd457fdcb9fa2483de22d3a
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 10 16:01:26 2017 +1200

Bug 1681289: Fixed error when adding views to a copied collection

Change-Id: Ie8687e7b1577bdcf00bf90cb403170280f56a06c
behatnotneeded: no change in functionality

[Mahara Bot (dev-mahara)]

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7655

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7655
Committed: https://git.mahara.org/mahara/mahara/commit/0f6428f212a1fdc2765b1c0857466644096567e2
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 0f6428f212a1fdc2765b1c0857466644096567e2
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 10 16:01:26 2017 +1200

Bug 1681289: Fixed error when adding views to a copied collection

Change-Id: Ie8687e7b1577bdcf00bf90cb403170280f56a06c
behatnotneeded: no change in functionality
(cherry picked from commit c156c8fd5a6613ca0cd457fdcb9fa2483de22d3a)