The alignmnet of buttons are improper when a member is invited to join Institution

Bug #1680640 reported by Niranjan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Pat
17.04
Fix Released
Medium
Pat
17.10
Fix Released
Medium
Liam

Bug Description

Tested on
Site: https://master-mahara.catalystdemo.net.nz
Browser: Safari 10.0.3/chrome/firefox
Device: MacBook Pro/Desktop

Steps to Reproduce:

1) Create an institution and invite an existing user on the site to become a member
2) Login as the user and go to Main menu -> Groups -> Institution membership

The "Join institution" and "Decline" buttons should have the same class as "Leave institution" or "Cancel request" buttons. They seem to be missing a class.

Also, the "Decline" button is all by itself underneath the institution and it looks like it is meant to decline everything, not just the immediate request.

Tags: front-end
Revision history for this message
Niranjan (niranjan528) wrote :
Changed in mahara:
status: New → Confirmed
importance: Undecided → Medium
tags: added: front-end
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7614

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7618

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7630

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7614
Committed: https://git.mahara.org/mahara/mahara/commit/ac7d4ab42df0c4c6d52a8fb79fa70c441e0ef2cb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ac7d4ab42df0c4c6d52a8fb79fa70c441e0ef2cb
Author: Liam <email address hidden>
Date: Tue Apr 11 12:36:26 2017 +1200

Bug: 1680640: Added btn-default classes to buttons on institution membership page

ToDo: Align buttons on same line

behatnotneeded

Change-Id: I11cfa4a3c2039e539289bc24e33c70eea3453d1d

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7630
Committed: https://git.mahara.org/mahara/mahara/commit/63316dcc44518df5e6f5ad53ead05d47aee7d594
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 63316dcc44518df5e6f5ad53ead05d47aee7d594
Author: Robert Lyon <email address hidden>
Date: Thu Apr 13 11:12:02 2017 +1200

Bug 1680640: Allow multiple submit buttons from one pieform element

Calling it multisubmit where we pass in an arrays of options/values so
that it sets up a bunch of 'submit' buttons that all flow thru the
same [formname]_submit function and be handled there.

This allows the submit buttons to 'live together' on the page and in
the code.

behatnotneeded

Change-Id: I16864d46ff3ea6bc0cb89e7769ba4caa5c20e53e
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7650

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7650
Committed: https://git.mahara.org/mahara/mahara/commit/1283811f3a41a539de7d78e2e53b3bb88f66169f
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 1283811f3a41a539de7d78e2e53b3bb88f66169f
Author: Liam <email address hidden>
Date: Tue Apr 11 12:36:26 2017 +1200

Bug: 1680640: Added btn-default classes to buttons on institution membership page

ToDo: Align buttons on same line

behatnotneeded

Change-Id: I11cfa4a3c2039e539289bc24e33c70eea3453d1d
(cherry picked from commit ac7d4ab42df0c4c6d52a8fb79fa70c441e0ef2cb)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7651

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7651
Committed: https://git.mahara.org/mahara/mahara/commit/6d0571751c12e210106831e14c9316c396b32dbd
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 6d0571751c12e210106831e14c9316c396b32dbd
Author: Robert Lyon <email address hidden>
Date: Thu Apr 13 11:12:02 2017 +1200

Bug 1680640: Allow multiple submit buttons from one pieform element

Calling it multisubmit where we pass in an arrays of options/values so
that it sets up a bunch of 'submit' buttons that all flow thru the
same [formname]_submit function and be handled there.

This allows the submit buttons to 'live together' on the page and in
the code.

behatnotneeded

Change-Id: I16864d46ff3ea6bc0cb89e7769ba4caa5c20e53e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 63316dcc44518df5e6f5ad53ead05d47aee7d594)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.