Adding Web service external app ensures 'webservice' auth method set for institution

Bug #1678668 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
17.04
Fix Released
Medium
Unassigned
17.10
Fix Released
Medium
Unassigned

Bug Description

Whne setting up an External App (OAuth) webservice application it won't work until we add 'Web services' authentication instance to the institution that the application is to be connected to.

As this step is outside the 'Web services' section it would be nicer if we can detect and add/update the authentication instance as part of saving of the application instance.

This is possible due to:

A) The webservice auth instance does not have a configuration menu
B) Currently all external apps need to have 'webservice' auth set

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 17.04.1
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7594

Changed in mahara:
milestone: 17.04.1 → 17.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7594
Committed: https://git.mahara.org/mahara/mahara/commit/bfa5f882b5dc2e1d9eff01ac3aeaa0f71bac35e0
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit bfa5f882b5dc2e1d9eff01ac3aeaa0f71bac35e0
Author: Robert Lyon <email address hidden>
Date: Mon Apr 3 09:15:15 2017 +1200

Bug 1678668: Adding webservice auth via adding external app

When we add an app configuration via
Administration -> Webservices -> External apps

We can check and make sure the 'webservice' auth instance exists for
the institution we choose.

behatnotneeded

Change-Id: I5012346c290ad94990cd48dcc1e5dc5b9ee694d9
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7646

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7646
Committed: https://git.mahara.org/mahara/mahara/commit/099169f24e522acac9f6cf6085f775b001f5a86e
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 099169f24e522acac9f6cf6085f775b001f5a86e
Author: Robert Lyon <email address hidden>
Date: Mon Apr 3 09:15:15 2017 +1200

Bug 1678668: Adding webservice auth via adding external app

When we add an app configuration via
Administration -> Webservices -> External apps

We can check and make sure the 'webservice' auth instance exists for
the institution we choose.

behatnotneeded

Change-Id: I5012346c290ad94990cd48dcc1e5dc5b9ee694d9
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit bfa5f882b5dc2e1d9eff01ac3aeaa0f71bac35e0)

tags: added: usermanualupdate
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.