PHP7 deprecated constructor for xmldb

Bug #1677063 reported by Robert Lyon on 2017-03-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon

Bug Description

On upgrade I get these errors in error.log

PHP Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; XMLDBpostgres has a deprecated constructor in /home/robertl/code/mahara-devel/mahara/htdocs/lib/xmldb/classes/generators/postgres/postgres.class.php on line 31

We need to update the lib/xmldb/ files so classes are constructed correctly

eg

Replace

public function XMLDBpostgres($host, $queryPort)

with

public function __construct($host, $queryPort)

Robert Lyon (robertl-9) on 2017-03-28
Changed in mahara:
milestone: none → 17.04.0
importance: Undecided → Medium
status: New → Confirmed
Robert Lyon (robertl-9) on 2017-03-29
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Robert Lyon (robertl-9)

Reviewed: https://reviews.mahara.org/7578
Committed: https://git.mahara.org/mahara/mahara/commit/c4d74eb06bf9cf25eb6dbbf10d3e680b3ae82155
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit c4d74eb06bf9cf25eb6dbbf10d3e680b3ae82155
Author: Robert Lyon <email address hidden>
Date: Thu Mar 30 09:58:14 2017 +1300

Bug 1677063: Using correct constructor in XMLDB* classes

behatnotneeded - install of site is good test of this change

Change-Id: I9697ad19afa7e0167aad5b4b468fd86de4132252
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw) on 2017-03-30
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2017-04-27
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers