group member sees p&c as a list, not boxes

Bug #1676230 reported by Cecilia Vela Gurovic on 2017-03-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon

Bug Description

If we have a user with role=member in a group, and this role cant edit the pages at the moment, the p&c screen of the group shows:

1. An error

[WAR] d3 (view/groupviews.php:61) Undefined variable: orderby

This is fixed removing parameter
  'orderby' => $orderby,
in the pagination configuration in views/groupviews.php. It is ok to remove because we have the parameter repeted and variable $orderby is not defined.

2. After fixing the error, the pages are displayed in a list and the collections can't be seen. They should all be displayed as boxes.

summary: - group memeber sees p&c as a list, not boxes
+ group member sees p&c as a list, not boxes
Robert Lyon (robertl-9) on 2017-03-26
Changed in mahara:
importance: Undecided → High
assignee: nobody → Robert Lyon (robertl-9)
status: New → In Progress

Reviewed: https://reviews.mahara.org/7567
Committed: https://git.mahara.org/mahara/mahara/commit/8695ca39014060c604c905aa0c697b8e76840ee6
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 8695ca39014060c604c905aa0c697b8e76840ee6
Author: Robert Lyon <email address hidden>
Date: Mon Mar 27 14:12:51 2017 +1300

Bug 1676230: Style group view list page for non-editable member correctly

Previously we had a pair of different templates for this - but we just
need to have a flag to hide edit buttons when one can't doesn't have
edit rites

behatnotneeded

Change-Id: Iff591157ea787f25163c1243789337eceb95b2fd
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2017-03-31
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2017-04-27
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers