HTML export links to actual files rather than local files

Bug #1669128 reported by Kristina Hoeppner
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Kevin Dibble

Bug Description

When you export a portfolio in HTML and have a file on a page, the file's link goes to the original location of the site whereas the download link goes to the local site.

Therefore, if a user clicks the link, they often need to log into the original site or if the account was removed can't access their file. Whereas if they click to download the file, they can do so. The links should always go to the local file rather than the original location esp. since the file is saved in the HTML export.

Tags: export
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Fergus Whyte (fergusw) wrote :

Hi,
Just wanted to say that I've been looking at this issue. Can I claim this bug?

Thanks,
Fergus

Changed in mahara:
assignee: nobody → Fergus Whyte (fergusw)
Changed in mahara:
status: Confirmed → In Progress
Changed in mahara:
assignee: Fergus Whyte (fergusw) → nobody
status: In Progress → Confirmed
tags: added: export
Changed in mahara:
assignee: nobody → Kevin Dibble (digitalskill)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10231

Revision history for this message
Steven (stevens-q) wrote :

Commit hash: b1f1935c1f9a632f7d2bcb04d8b6d184296e076a
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) User1 has a portfolio page as follows:
    a) Image block
    b) files to download block - with 1 image file and 1 doc file
2) The page was exported as an html file

TEST STEPS:
------------------------
1) Open the downloaded html file for the page mentioned above
2) Verify that the image file does not redirect user to the original site page ✔
3) Verify that the doc file does not redirect user to the original site page ✔
4) Click on the image on the page
5) Verify that the image does not redirect user to the original site page ✔

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10231
Committed: https://git.mahara.org/mahara/mahara/commit/75388eea64ff582695e31555c45985684287d21b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 75388eea64ff582695e31555c45985684287d21b
Author: Kevin Dibble <email address hidden>
Date: Wed Jul 31 12:29:31 2019 +1200

Bug 1669128: HMTL Filters for Export

Updated HTML filters to include links to artefacts to be local.

behatnotneeded

Change-Id: If21da8e0d5bb852463bd92211fd7b6a2d694962d

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → Fix Committed
milestone: none → 19.10.0
Lisa Seeto (lisaseeto)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.