page theme brakes when changing theme settings in institution
Bug #1668492 reported by
Cecilia Vela Gurovic
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Cecilia Vela Gurovic |
Bug Description
For a normal user that is part of more than one institution:
In user settings, select as a theme one of the institution themes that is different from raw/default
Create a page, it will have the selected theme.
If we now, as a site admin, change that institution theme for Configurable theme,
1. the page will still have the old theme.
2. When the normal user creates a smartevidence collection including that page, the first page of the collection will show the wrong theme.
Changed in mahara: | |
assignee: | nobody → Cecilia Vela Gurovic (ceciliavg) |
status: | New → In Progress |
description: | updated |
summary: |
- page theme brakes when changing them settings in institution + page theme brakes when changing theme settings in institution |
Changed in mahara: | |
importance: | Undecided → Medium |
status: | In Progress → Fix Committed |
tags: | added: usermanualupdate |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The way that is working now:
1. If the user sets a personal theme in account settings, when it creates a page the theme will be saved in the view table on the DB for that page. Every time the user sees the page, it will show this theme. Even if the user changes the theme on the account settings, the page will be displayed with old theme.
The part of the code that does this is old, it was added before the user could change the theme in the account settings. It was made to take the user institution's theme.
But now, the user can change the account setting theme any time.
2. For the smart evidence collection, the matrix view (first on the collection) will pick the theme/skin from the first page of the collection. So if the first page has a wrong theme hardcoded in the DB, the matrix view will show the wrong theme. Fixing the first issue will fix this one too.
The solution I see is allowing to set the theme in view table on the DB only when iewthemes = true and
we have userscanchoosev
the theme is set when we are editing page
for any other pages created, the system should decide which theme to show based on the user, institution and site settings.