Journal comments can't be viewed on a page

Bug #1664582 reported by Christina on 2017-02-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
15.10
High
Unassigned
16.04
High
Unassigned
16.10
High
Unassigned
17.04
High
Unassigned
17.10
High
Robert Lyon

Bug Description

Mahara version: 16.10.0
OS: Windows and OSX
Browser: Chrome Version 53.0.2785.116 m, Firefox 51.0.1 (32-bit), Safari

Students have added their journals to a group page, but when moving to page two or beyond in the journal are unable to see comments unless accessing the journal entry directly. When clicking on the comment link, students are ported to the top of the page instead of a comment loading on the right side of the page. On page 1, students are able to see comments normally.

Can you please say how the students added their journals to the group page?

Changed in mahara:
status: New → Incomplete
Christina (christina.m) wrote :

Students create a page in Mahara, add their journals to the page with 5 entries per page, have a full page layout, and then share their page with the creative writing group under the share page link at the top of the new page (Display page Share page). Under that link, a page is displayed that says "shared with" and a specific group (creative writing) and specific users (in this case, me) are added to the shared with column with no specific dates attached. Comments are allowed, comments are not moderated and copying is not allowed. Does this help?

Thanks so much for your assistance!

summary: - comments on added journals won't show after page 1
+ Journal comments can't be viewed on a page
Changed in mahara:
status: Incomplete → Confirmed
importance: Undecided → High
milestone: none → 17.04.0

Thank you for the information, Christina. I could replicate the system on Mahara master as well. Now we only need to check if it also affects 16.04 and 15.10.

Here are the steps to replicate:

1. Create a journal with 11 entries.
2. Add the journal to a page and make sure the number of entries displayed is 5 (so we get a paginator).
3. Add a couple of comments to individual journal entries on page 1 of journal entries.
4. Add a couple of comments to journal entries after clicking the journal paginator and moving to page.
5. Click the "Comments" on page one where there are comments -> They show up in a modal.
6. Click the paginator and move to page 2 of the journal and click "Comments" for a journal entries that has comments -> The modal doesn't open up but the page just jumps to the top.

Niranjan (niranjan528) wrote :

I have tested it on

Mahara version: 15.10.0
OS: Windows and OSX
Browser: Chrome Version 53, Firefox 51, Safari

and the result is same, the modal doesn't open up but the page jumps to top. I have used the steps to reproduce by using the previous comments from Kristina.

Robert Lyon (robertl-9) on 2017-03-26
Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Confirmed → In Progress
Robert Lyon (robertl-9) wrote :

Patch for this
https://reviews.mahara.org/#/c/7663/

It detects pagination event and re-wires up the modal triggers on the page allowing the comments modal to activate for pages other than page 1.

Reviewed: https://reviews.mahara.org/7663
Committed: https://git.mahara.org/mahara/mahara/commit/f87515a872f33f080674bd953d675d0e14721446
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f87515a872f33f080674bd953d675d0e14721446
Author: Robert Lyon <email address hidden>
Date: Thu Apr 20 22:54:19 2017 +1200

Bug 1664582: Rewire the modal dock triggers after pagination

When going to another page of pagination it rewires up the modal connections
Works on page view and page edit screens

behatnotneeded

Change-Id: Ic38cf3e03272849c3a278ed40360c634e1472ae9
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7678

Mahara Bot (dev-mahara) wrote :

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7679

Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/7680

Reviewed: https://reviews.mahara.org/7677
Committed: https://git.mahara.org/mahara/mahara/commit/01fd2b582966f3c726f0400bcd55ef2c8b9719b6
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 01fd2b582966f3c726f0400bcd55ef2c8b9719b6
Author: Robert Lyon <email address hidden>
Date: Thu Apr 20 22:54:19 2017 +1200

Bug 1664582: Rewire the modal dock triggers after pagination

When going to another page of pagination it rewires up the modal connections
Works on page view and page edit screens

behatnotneeded

Change-Id: Ic38cf3e03272849c3a278ed40360c634e1472ae9
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit f87515a872f33f080674bd953d675d0e14721446)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7680
Committed: https://git.mahara.org/mahara/mahara/commit/97a6406fc8a36b58235ad06aa736a475e90a479d
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 97a6406fc8a36b58235ad06aa736a475e90a479d
Author: Robert Lyon <email address hidden>
Date: Thu Apr 20 22:54:19 2017 +1200

Bug 1664582: Rewire the modal dock triggers after pagination

When going to another page of pagination it rewires up the modal connections
Works on page view and page edit screens

behatnotneeded

Change-Id: Ic38cf3e03272849c3a278ed40360c634e1472ae9
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit f87515a872f33f080674bd953d675d0e14721446)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7678
Committed: https://git.mahara.org/mahara/mahara/commit/cd6e2fbe2c4aa8f7fb426941532b8421f2073d5e
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit cd6e2fbe2c4aa8f7fb426941532b8421f2073d5e
Author: Robert Lyon <email address hidden>
Date: Thu Apr 20 22:54:19 2017 +1200

Bug 1664582: Rewire the modal dock triggers after pagination

When going to another page of pagination it rewires up the modal connections
Works on page view and page edit screens

behatnotneeded

Change-Id: Ic38cf3e03272849c3a278ed40360c634e1472ae9
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit f87515a872f33f080674bd953d675d0e14721446)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7679
Committed: https://git.mahara.org/mahara/mahara/commit/810e3a52f5bdc9c8c3e704edfe454952234c0eb0
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 810e3a52f5bdc9c8c3e704edfe454952234c0eb0
Author: Robert Lyon <email address hidden>
Date: Thu Apr 20 22:54:19 2017 +1200

Bug 1664582: Rewire the modal dock triggers after pagination

When going to another page of pagination it rewires up the modal connections
Works on page view and page edit screens

behatnotneeded

Change-Id: Ic38cf3e03272849c3a278ed40360c634e1472ae9
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit f87515a872f33f080674bd953d675d0e14721446)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers