Creating a new institution is not setting $newinstitution->defaultmembershipperiod as null but rather as '0'

Bug #1654894 reported by Robert Lyon on 2017-01-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon
15.10
Medium
Unassigned
16.04
Medium
Unassigned
16.10
Medium
Unassigned
17.04
Medium
Robert Lyon

Bug Description

This in turn shows the default membership period as '0 days' on the config form, which is incorrect as it should show 'no end date'

Robert Lyon (robertl-9) on 2017-01-08
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
milestone: none → 17.04.0
assignee: nobody → Robert Lyon (robertl-9)
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7384

Reviewed: https://reviews.mahara.org/7384
Committed: https://git.mahara.org/mahara/mahara/commit/e2a12725c961a2c071497838375981c1c385a540
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e2a12725c961a2c071497838375981c1c385a540
Author: Robert Lyon <email address hidden>
Date: Mon Jan 9 11:17:29 2017 +1300

Bug 1654894: Institution defaultmembershipperiod being set to 0

Rather than being set as null

behatnotneeded

Change-Id: I87ad0bea91ca7df747ee2a5fed731ceef29f434d
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2017-02-15
Changed in mahara:
status: In Progress → Fix Committed
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7383
Committed: https://git.mahara.org/mahara/mahara/commit/a54fedef75035d103fa2e77d8069c73e9bba10ed
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit a54fedef75035d103fa2e77d8069c73e9bba10ed
Author: Robert Lyon <email address hidden>
Date: Mon Jan 9 11:17:29 2017 +1300

Bug 1654894: Institution defaultmembershipperiod being set to 0

Rather than being set as null

behatnotneeded

Change-Id: I87ad0bea91ca7df747ee2a5fed731ceef29f434d
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7467

Reviewed: https://reviews.mahara.org/7467
Committed: https://git.mahara.org/mahara/mahara/commit/dc7426ad3a22719d529ed65a389781de94dc002f
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit dc7426ad3a22719d529ed65a389781de94dc002f
Author: Robert Lyon <email address hidden>
Date: Mon Jan 9 11:17:29 2017 +1300

Bug 1654894: Institution defaultmembershipperiod being set to 0

Rather than being set as null

behatnotneeded

Change-Id: I87ad0bea91ca7df747ee2a5fed731ceef29f434d
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit e2a12725c961a2c071497838375981c1c385a540)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7466
Committed: https://git.mahara.org/mahara/mahara/commit/22265c4229dadf0613e76ed7683dbeee10ebc61b
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 22265c4229dadf0613e76ed7683dbeee10ebc61b
Author: Robert Lyon <email address hidden>
Date: Mon Jan 9 11:17:29 2017 +1300

Bug 1654894: Institution defaultmembershipperiod being set to 0

Rather than being set as null

behatnotneeded

Change-Id: I87ad0bea91ca7df747ee2a5fed731ceef29f434d
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit e2a12725c961a2c071497838375981c1c385a540)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers