Page editing all on one page

Bug #1652245 reported by Antonella DC
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
In Progress
Wishlist
Unassigned

Bug Description

Hello, here is the list of Mahara files (version 16.04 ) modified by Eticeo Santé and the code modified / created as an attachment.

Step 1
Title, description a layout merged in one single page.
Step 2
Content of the page.
Step 3
Sharing option with the 2 way of sharing (internal and secret url) merged in one single page.

Technical explanation :

Files modified :

view/blocks.php (the user cannot change the theme)
lib/view.php (redirections)

Files created :

view/accessurl.php (access + url)
view/editlayout.php (edit + layout)

New Theme Raw 2 (parent theme) :

theme/raw2/pieforms/viewlayout.php (add the edit fields)
theme/raw2/pieforms/new.css (css for the tabs)
theme/raw2/themeconfig.php (the parent is raw)
theme/raw2/templates/view/accessurl.tpl (view of the page)
theme/raw2/templates/view/editlayout.tpl (view of the page)
theme/raw2/templates/view/editviewtabs.tpl (system of tabs modified)
theme/raw2/images/number-one-in-a-circle-grey.png (image for the tab 1)
theme/raw2/images/number-two-in-a-circle-grey.png (image for the tab 2)
theme/raw2/images/number-three-in-a-circle-grey.png (image for the tab 3)

Surely there are many errors, I don't know if it corresponds to the Mahara style.
I hope to have forgotten nothing !

Thank you for your advices and feedback !

Revision history for this message
Antonella DC (antonella88) wrote :
description: updated
description: updated
Revision history for this message
Lilian HUGUES (lilian-hugues) wrote :

Many thanks Antonella for your sharing.

Kristina,
As we have discussed, it could be nice if your team could have a look on the Antonella job.

This way of creating pages is a huge improvment in terms of ergonomics... Maybe can it be implemented in a future release.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Hi Antonella and Lilian. Thanks for the code. Robert is going to put it into our review system so we can take a look.

Changed in mahara:
importance: Undecided → Wishlist
status: New → In Progress
milestone: none → 17.04.0
summary: - Ergonomic changes : the creation process of a portfolio's page in three
- steps
+ Page editing all on one page
Revision history for this message
Robert Lyon (robertl-9) wrote :

I've added the code to the reviews system - the differences I made were to merge the 'raw2' theme with the 'raw' one and add the 'new.css' information to the bottom of the 'htdocs/theme/raw/sass/_custom.scss' file

Revision history for this message
Robert Lyon (robertl-9) wrote :

Hi Antonella,

See https://reviews.mahara.org/#/c/7366/ for the initial patch - let me know if there is anything missing from the patch

Cheers

Robert

Changed in mahara:
milestone: 17.04.0 → 17.10.0
milestone: 17.10.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.