MySql fallback not working in 16.10

Bug #1649732 reported by Robert Lyon on 2016-12-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Cecilia Vela Gurovic
16.10
High
Unassigned
17.04
High
Cecilia Vela Gurovic

Bug Description

In init.php file there is a check to make sure that if one is using a mysql database they are using either database type 'mysqli' or 'mysql'. And they relate to drivers in htdocs/lib/adodb/drivers/

But we removed the ADODB driver for 'mysql' so we can't fall back to that one any more.
See commit 2f19a42ddd6af732e40b1aae9359ee80e28f9111

We need to tidy up the init.php file (around line 133) to throw error if 'mysqli' PHP extension is not installed rather than trying to use 'mysql' as database type.

Reviewed: https://reviews.mahara.org/7364
Committed: https://git.mahara.org/mahara/mahara/commit/94bc0a81e165c292ab569c7c7e4c72803ca98261
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 94bc0a81e165c292ab569c7c7e4c72803ca98261
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Dec 23 12:09:26 2016 +1300

Bug 1649732: Show error message when using mysql

mysql php module is not supported any more.
mysqli should be used instead and show an error if not.

behatnotneeded

Change-Id: I018b5117f33ed6788be45a756b045870156833da

Reviewed: https://reviews.mahara.org/7391
Committed: https://git.mahara.org/mahara/mahara/commit/f78da224c11765b968ae2ce234b2baf57675e972
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit f78da224c11765b968ae2ce234b2baf57675e972
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Dec 23 12:09:26 2016 +1300

Bug 1649732: Show error message when using mysql

mysql php module is not supported any more.
mysqli should be used instead and show an error if not.

behatnotneeded

Change-Id: I018b5117f33ed6788be45a756b045870156833da
(cherry picked from commit 94bc0a81e165c292ab569c7c7e4c72803ca98261)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers