Consolidate "Add file" buttons

[Kristina Hoeppner]

We use two different ways of adding files to a text box / resume sections etc.: One, which allows you to add files from both your Mahara storage and computer and another one only from the computer. The latter one is the older one and can still be found in certain places.

We should consolidate the occurances to always use the new way of adding files to be more consistent.

Best case in point:

When you add a file to your education history, you get the old button. However, when you edit that entry, you get the new button (see attachment).

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/7945

[Pramith Dayananda (pramithkm)]

Hi,

I've pushed a patch for "Achievements" section. It's better to make sure the code I provided is reviewed before applying this change to "Education and employment".

Thanks,
Pramith.

[Steven (stevens-q)]

Environment tested: Master
Browser tested: Chrome

===================
Manual Test Script
===================

Preconditions:
 1. Group exists

Test Steps:
1. User logged in
2. User browse to Main menu > Content > Resume
3. Confirm that the date is in the same format as when created using the old date picker ✔
4. Confirm the date picker is displayed when the user clicks inside the date field ✔
5. Confirm the user can enter a date by typing in a date using the keyboard ✔
6. Confirm the user can change a day inside the date picker by clicking the adjacent number in the calendar ✔
7. Confirm the user can change the month by
 a. Clicking the forward > icon ✔
 b. Clicking the month and year located in centre of modal window at the top ✔
 c. Confirm months are now displayed instead of days and year is displayed in centre of modal window at the top ✔
8. Confirm the user can change the year inside the date picker by clicking the month and year located in centre of modal window at the top ✔
9. Confirm years are now displayed instead of days and a year range is displayed in centre of modal window at the top ✔
10. Confirm the user can delete the date by clicking the trash can icon ✔
11. Confirm that all date pickers across the site have been updated to the new date picker
 a. Main menu > Content > Resume > introduction - Date picker changed ✔
 b. Main menu > Content > Plans > (click - plan name) > New task - Date picker changed ✔
 c. Main menu > Groups > (click on group) > Share > Edit access - Date picker changed ✔
 d. Admin > Reports > Configure report - Date picker changed ✔

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12081

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12081
Committed: https://git.mahara.org/mahara/mahara/commit/05584c369242146f02fc1380f91b03401f69e1a2
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 05584c369242146f02fc1380f91b03401f69e1a2
Author: Pramith Dayananda <email address hidden>
Date: Thu Aug 24 14:17:13 2017 +1200

Bug 1649433: Resume, replace old fileupload field with filebrowser

Notes from Pramith:
@TODO: file uploader closes popup and does not refresh content
- I fixed this but needs to be done in a nicer way
The problem comes from the filebrowser pieform: when adding a
new file, it call the callback js function of the form.
In other places in mahara, this is fine because the forms
didn't need to set the callback so it could be used by the filebrowser element.
But in this page, the form sets the callback to be compositeSaveCallback

Notes from Dianne:
- Replaced 'attachments' key with 'filebrowser' key in employment and
education history classes. This gets correct filebrowser working.
- Fixed the 'Edit' button in 'Achievements' and 'Education and Employment'
by updating js
- Added employment and education callbacks to compositeSaveCallback

Change-Id: I02f881ddde59e82dcc0e9e973195c557d9925bed