Declaration issuesfor PHP7 on CLI install

Bug #1649177 reported by Robert Lyon on 2016-12-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Unassigned

Bug Description

There are these errors on CLI install in master

[WAR] 7e (artefact/file/blocktype/internalmedia/lib.php:443) Declaration of MaharaMediaPlayer_flash::get_unique_id($artefact, $block) should be compatible with MaharaMediaPlayer::get_unique_id(ArtefactType $artefact, BlockInstance $block)
Call stack (most recent first):
  * log_message("Declaration of MaharaMediaPlayer_flash::get_unique...", 8, true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 443) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:521
  * error(2, "Declaration of MaharaMediaPlayer_flash::get_unique...", "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 443, array(size 10)) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569
  * require_once() at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569
  * safe_require("blocktype", "file/internalmedia") at /home/robertl/code/mahara-devel/mahara/htdocs/lib/upgrade.php:239
  * check_upgrades() at /home/robertl/code/mahara-devel/mahara/htdocs/admin/cli/install.php:67

[WAR] 7e (artefact/file/blocktype/internalmedia/lib.php:623) Declaration of MaharaMediaPlayer_html5audio::get_unique_id($artefact, $block) should be compatible with MaharaMediaPlayer::get_unique_id(ArtefactType $artefact, BlockInstance $block)
Call stack (most recent first):
  * log_message("Declaration of MaharaMediaPlayer_html5audio::get_u...", 8, true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 623) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:521
  * error(2, "Declaration of MaharaMediaPlayer_html5audio::get_u...", "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 623, array(size 10)) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569
  * require_once() at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569
  * safe_require("blocktype", "file/internalmedia") at /home/robertl/code/mahara-devel/mahara/htdocs/lib/upgrade.php:239
  * check_upgrades() at /home/robertl/code/mahara-devel/mahara/htdocs/admin/cli/install.php:67

[WAR] 7e (artefact/file/blocktype/internalmedia/lib.php:623) Declaration of MaharaMediaPlayer_html5audio::get_js_initjs(ArtefactTypeFile $artefact, BlockInstance $block, $width, $height) should be compatible with MaharaMediaPlayer::get_js_initjs(ArtefactType $artefact, BlockInstance $block, $width, $height)
Call stack (most recent first):
  * log_message("Declaration of MaharaMediaPlayer_html5audio::get_j...", 8, true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 623) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:521
  * error(2, "Declaration of MaharaMediaPlayer_html5audio::get_j...", "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 623, array(size 10)) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569
  * require_once() at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569
  * safe_require("blocktype", "file/internalmedia") at /home/robertl/code/mahara-devel/mahara/htdocs/lib/upgrade.php:239
  * check_upgrades() at /home/robertl/code/mahara-devel/mahara/htdocs/admin/cli/install.php:67

[WAR] 7e (artefact/file/blocktype/internalmedia/lib.php:680) Declaration of MaharaMediaPlayer_html5video::get_unique_id($artefact, $block) should be compatible with MaharaMediaPlayer::get_unique_id(ArtefactType $artefact, BlockInstance $block)
Call stack (most recent first):
  * log_message("Declaration of MaharaMediaPlayer_html5video::get_u...", 8, true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 680) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:521
  * error(2, "Declaration of MaharaMediaPlayer_html5video::get_u...", "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 680, array(size 10)) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569
  * require_once() at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569
  * safe_require("blocktype", "file/internalmedia") at /home/robertl/code/mahara-devel/mahara/htdocs/lib/upgrade.php:239
  * check_upgrades() at /home/robertl/code/mahara-devel/mahara/htdocs/admin/cli/install.php:67

[WAR] 7e (artefact/file/blocktype/internalmedia/lib.php:680) Declaration of MaharaMediaPlayer_html5video::get_js_initjs(ArtefactTypeFile $artefact, BlockInstance $block, $width, $height) should be compatible with MaharaMediaPlayer::get_js_initjs(ArtefactType $artefact, BlockInstance $block, $width, $height)
Call stack (most recent first):
  * log_message("Declaration of MaharaMediaPlayer_html5video::get_j...", 8, true, true, "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 680) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/errors.php:521
  * error(2, "Declaration of MaharaMediaPlayer_html5video::get_j...", "/home/robertl/code/mahara-devel/mahara/htdocs/arte...", 680, array(size 10)) at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569
  * require_once() at /home/robertl/code/mahara-devel/mahara/htdocs/lib/mahara.php:1569
  * safe_require("blocktype", "file/internalmedia") at /home/robertl/code/mahara-devel/mahara/htdocs/lib/upgrade.php:239
  * check_upgrades() at /home/robertl/code/mahara-devel/mahara/htdocs/admin/cli/install.php:67

Robert Lyon (robertl-9) on 2016-12-12
Changed in mahara:
importance: Undecided → Medium
milestone: none → 17.04.0
status: New → In Progress

Reviewed: https://reviews.mahara.org/7324
Committed: https://git.mahara.org/mahara/mahara/commit/5de73f74a826837e8772936eb88ad449f5e1103b
Submitter: Ghada El-Zoghbi (<email address hidden>)
Branch: master

commit 5de73f74a826837e8772936eb88ad449f5e1103b
Author: Robert Lyon <email address hidden>
Date: Mon Dec 12 16:35:09 2016 +1300

Bug 1649177: PHP7 declaration compatibility issues in internalmedia blocks

behatnotneeded

Change-Id: Iece5a0dc5cbdfa52bcced3923a0259834380cd31
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2017-04-27
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers