The plan tasks list completed icons are not aligned correctly

Bug #1648870 reported by Gilles-Philippe Leblanc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Liam

Bug Description

To reproduce:
* Go to Content > Plans
* Create a plan and some tasks
** Set some task to complete and some with a due date in the past
* Resize the Windows of your browser horizontally
Actual: the icons in the first column are not correctly align with the "Completed" header
Expected : Centered icon in a fixed width column based on the size of the header "Completed"

Tags: front-end
Revision history for this message
Gilles-Philippe Leblanc (gilles-philippe-leblanc) wrote :
Changed in mahara:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 17.04.0
tags: added: front-end
Changed in mahara:
assignee: nobody → Liam (liam-sharpe)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7326

Liam (liam-sharpe)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Gilles-Philippe Leblanc (gilles-philippe-leblanc) wrote :

Hi, I have a fix for this bug but I just need some time to share it with you. Thank you!
I see you have already a fix for it but mines is a little different. Maybe we can compare to find the better solution. Thanks!

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Let us know what your fix is and we'll compare during code review. :-)

You can log into reviews.mahara.org and actually comment directly on the files rather than submitting a patch if it is just a small change. If the change is entirely different, then submit a patch and we'll see which one will make it through.

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7356

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7356
Committed: https://git.mahara.org/mahara/mahara/commit/3c0763be3ae161d282ffa07ee8ffb077864956b3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3c0763be3ae161d282ffa07ee8ffb077864956b3
Author: Gilles-Philippe Leblanc <email address hidden>
Date: Fri Dec 9 14:20:22 2016 -0500

Bug 1648870: Fix plan tasks list completed icons alignment

- Move style.css file in plan plugintype to sass features folder since
the plugin is part of Mahara core
- Add classes in task related templates for future styling
- Use task-status class to apply some styles that will force task-status
cell to be only as wide as it needs to be
- Remove styles that are not used

behatnotneeded: CSS changes only

Change-Id: Ie1704c8b54bd139ecfcbc8337fff2f3448553048

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.