The file list overflow incorrectly with mobile devices

Bug #1648858 reported by Gilles-Philippe Leblanc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Liam

Bug Description

To reproduce:
* Go to Content > Files
* Add a file with a long name (ex. super_long_file_name_that_breaks_the_layout.jpg)
Actual: With mobile devices, the table go outside the page layout
Expected: The table do not go outside the page layout but a scroll is added for that table

Tags: front-end
Revision history for this message
Gilles-Philippe Leblanc (gilles-philippe-leblanc) wrote :
Changed in mahara:
importance: Undecided → Medium
status: New → Confirmed
milestone: none → 17.04.0
tags: added: front-end
Changed in mahara:
assignee: nobody → Liam (liam-sharpe)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7328

Liam (liam-sharpe)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Gilles-Philippe Leblanc (gilles-philippe-leblanc) wrote :

Hi, I have a fix for this bug but I just need some time to share it with you (at the end this week) Thank you!
I see you have already a fix for it but mines is a little different. Maybe we can compare to find the better solution. Thanks!

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Gilles-Philippe, can you please take a look at the patch and see if that fixes your problem? The issue is not just mobile devices but also regular browsers when the file name is too long.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Happy to also take a look at your patch :-)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7328
Committed: https://git.mahara.org/mahara/mahara/commit/74137491ab02c1710981bd9c9a21ae29fb0f4eea
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 74137491ab02c1710981bd9c9a21ae29fb0f4eea
Author: Liam <email address hidden>
Date: Tue Dec 13 13:01:54 2016 +1300

Bug #1648858: Fixed table overflowing on small screens on files page

behatnotneeded

Change-Id: I00c8374f57070d96f75325b081ee399d577bd4c5

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.