The pop-up help window pops up when the content is too long

Bug #1648089 reported by Gilles-Philippe Leblanc on 2016-12-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Gilles-Philippe Leblanc
16.04
Medium
Unassigned
16.10
Medium
Unassigned
17.04
Medium
Gilles-Philippe Leblanc

Bug Description

To reproduce:
* Click on the menu: Content > file
* Click on the (i) icon after the License field
Expected: We may be able to read all its content
Actual: The top part is outside the screen (see Screen-shot)

Which browser do you use, Gilles-Philippe? I can't replicate it in the latest Firefox on Ubuntu.

Changed in mahara:
status: New → Incomplete

Hi Kristina,

We use the version 16.04. It's not related with the browser (we have the problem will all of them).
I just check with the latest version and I'm unable to reproduce it. I'm pretty sure it because the difference between both version is the content of the license message. It have much more text content in 16.04 than the latest version.

So we may consider it's fixed in latest for this specific license message but I worry if there is other help message with long content.

I have a fix for this bug but I just need some time to share it with you (at the end this week).
I may check if some help message is long enough in latest and if so, I'll share it with you.

When you submit your patch, can you please say the specific conditions where you've seen it so we can then also check that in 17.04dev?

If it is only a 16.04 issue you could provide the patch just for 16.04 rather than master. Otherwise, master is the way to go and we can then backport it.

Changed in mahara:
status: Incomplete → In Progress
assignee: nobody → Gilles-Philippe Leblanc (gilles-philippe-leblanc)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → In Progress
importance: Undecided → Medium

Reviewed: https://reviews.mahara.org/7347
Committed: https://git.mahara.org/mahara/mahara/commit/0b6cb89714ab18bcaa8b17654664c605b870ab17
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 0b6cb89714ab18bcaa8b17654664c605b870ab17
Author: Gilles-Philippe Leblanc <email address hidden>
Date: Tue Dec 6 18:03:06 2016 -0500

Bug 1648089: Fix help window position when content too long

behatnotneeded

Change-Id: I0fbbd64068f272a6977b9f3a927e5bca99bcf731
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2016-12-22
Changed in mahara:
milestone: none → 17.04.0
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7359

I think we may merge it in all version even if the example message is different in the latest version to avoid this problem again in the future in case we have a long help message again.

Reviewed: https://reviews.mahara.org/7359
Committed: https://git.mahara.org/mahara/mahara/commit/c89514ad2086e4215f4e9a5242bcf782fe5bb640
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c89514ad2086e4215f4e9a5242bcf782fe5bb640
Author: Gilles-Philippe Leblanc <email address hidden>
Date: Tue Dec 6 18:03:06 2016 -0500

Bug 1648089: Fix help window position when content too long

behatnotneeded

Change-Id: I0fbbd64068f272a6977b9f3a927e5bca99bcf731
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7358
Committed: https://git.mahara.org/mahara/mahara/commit/56b88ce0a2a3906c480a90d403e6a2c59f7ef129
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 56b88ce0a2a3906c480a90d403e6a2c59f7ef129
Author: Gilles-Philippe Leblanc <email address hidden>
Date: Tue Dec 6 18:03:06 2016 -0500

Bug 1648089: Fix help window position when content too long

behatnotneeded

Change-Id: I0fbbd64068f272a6977b9f3a927e5bca99bcf731
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers