Default no user icon not been found if using get profile icon by id

Bug #1646291 reported by Robert Lyon on 2016-12-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Robert Lyon
16.10
Low
Unassigned
17.04
Low
Robert Lyon

Bug Description

We need it to get ArtefactTypeProfileIcon::download_thumbnail() to cascade through the function ArtefactTypeProfileIcon::download_thumbnail_for_user() in case the icon we try to get by id has been deleted off the server - rather than leave a broken image link

Robert Lyon (robertl-9) on 2016-12-01
description: updated
Changed in mahara:
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 17.04.0
Robert Lyon (robertl-9) wrote :

To test

Create a site with at least 1 non-admin user, masquerade as them and set a profile picture.

Then go to you dataroot and find the profileicon under artefacts/file/profileicons/originals as delete the icon

In Ubuntu you can go: sudo -i nautilus
to open up a gui with permissions to view files in your dataroot making the finding of the file easier.

Without patch:
When you reload the page you should get a broken image

With patch:
When you reload the page you should get the default human outline icon

Reviewed: https://reviews.mahara.org/7274
Committed: https://git.mahara.org/mahara/mahara/commit/f3dd774f86bb312fee14509f1b07bba2700a89a4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f3dd774f86bb312fee14509f1b07bba2700a89a4
Author: Robert Lyon <email address hidden>
Date: Fri Nov 25 17:26:18 2016 +1300

Bug 1646291: Fixing problem with missing profile icons

behatnotneeded

Change-Id: Id1c51f16e1d9503348600033b2804411ad03ec78
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/7301
Committed: https://git.mahara.org/mahara/mahara/commit/7f069ca89822f5f759206cae8273a808a67b9688
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 7f069ca89822f5f759206cae8273a808a67b9688
Author: Robert Lyon <email address hidden>
Date: Fri Nov 25 17:26:18 2016 +1300

Bug 1646291: Fixing problem with missing profile icons

behatnotneeded

Change-Id: Id1c51f16e1d9503348600033b2804411ad03ec78
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit f3dd774f86bb312fee14509f1b07bba2700a89a4)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers