Submitted portfolios don't appear in group pages block automatically after editing group config

Bug #1644386 reported by Robert Lyon on 2016-11-24
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon
17.04
Medium
Unassigned
17.10
Medium
Robert Lyon

Bug Description

When we fixed bug 1582039 we forgot to handle the case when one is switching a group from one we can't submit to to now allow submissions.

This needs to be added - the fix will be similar to how we handle this when creating the group but in the group_update function

Robert Lyon (robertl-9) on 2016-11-24
Changed in mahara:
status: New → Confirmed
assignee: nobody → Robert Lyon (robertl-9)
importance: Undecided → High
Changed in mahara:
importance: High → Medium
Changed in mahara:
milestone: none → 17.04.0
Robert Lyon (robertl-9) on 2017-03-28
Changed in mahara:
milestone: 17.04.0 → 17.04.1
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7810

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7810
Committed: https://git.mahara.org/mahara/mahara/commit/4b4deb91c2400728c2a59ce8f1f038452854d093
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4b4deb91c2400728c2a59ce8f1f038452854d093
Author: Robert Lyon <email address hidden>
Date: Wed Jun 7 12:29:32 2017 +1200

Bug 1644386: Update block on group homepage if allowsubmissions change

Added db upgrade where we update only the existing groupviews blocks where:
1) the group is submittable to
2) no choice has been selected to view submissions

This way we don't accidentially overwrite a user's choice

behatnotneeded

Change-Id: Idd50fe3a75a7434cbbd5ff30d755708c9f855e7b
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7844

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7844
Committed: https://git.mahara.org/mahara/mahara/commit/38f71ea6120926a4e011fba27ec13647cd61ac91
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 38f71ea6120926a4e011fba27ec13647cd61ac91
Author: Robert Lyon <email address hidden>
Date: Wed Jun 7 12:29:32 2017 +1200

Bug 1644386: Update block on group homepage if allowsubmissions change

Added db upgrade where we update only the existing groupviews blocks where:
1) the group is submittable to
2) no choice has been selected to view submissions

This way we don't accidentially overwrite a user's choice

behatnotneeded

Change-Id: Idd50fe3a75a7434cbbd5ff30d755708c9f855e7b
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers