Error: Only variables should be passed by reference

Bug #1642745 reported by Cecilia Vela Gurovic on 2016-11-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Cecilia Vela Gurovic

Bug Description

When I go to page webservice/testclient.php

I see the error debug message:

"Only variables should be passed by reference"

This is coming from a call to array_shift() that has a call to array_keys() as a parameter.

We should assign the result from array_keys() to a variable and then call array_shift() with this variable as a parameter.

Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
milestone: none → 17.04.0
Changed in mahara:
status: New → In Progress

Reviewed: https://reviews.mahara.org/7258
Committed: https://git.mahara.org/mahara/mahara/commit/ec7dde1c31f04546d3671ad5d34941b103685b1f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ec7dde1c31f04546d3671ad5d34941b103685b1f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Nov 18 11:44:36 2016 +1300

Bug 1642745: Fix error Only variables should be passed by reference

Fixed error when

accessing page webservice/testclient.php
that showed a debug message "Only variables should
be passed by reference".

importing Leap2A file that showed same message.

behatnotneeded

Change-Id: I44d1bbb4303fcf50d633e62ff2e316cf28fa3c47

Robert Lyon (robertl-9) on 2016-11-29
Changed in mahara:
importance: Undecided → Medium
status: In Progress → Fix Committed
Robert Lyon (robertl-9) wrote :

I've noticed this warning in the Content -> Files section when uploading files and/or changing folders

Changed in mahara:
status: Fix Committed → In Progress
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2017-04-27
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers