Don't display submitted pages in 'shared with group' sections is broken for pagination

Bug #1639096 reported by Robert Lyon on 2016-11-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
15.10
High
Unassigned
16.04
High
Unassigned
16.10
High
Unassigned
17.04
High
Robert Lyon

Bug Description

The fix for https://bugs.launchpad.net/mahara/+bug/1386000 being https://reviews.mahara.org/#/c/6987/

Causes issues with the pagination for shared with group section

This is because the fix in the lib.php file was not duplicated in the .json.php files

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7230

Reviewed: https://reviews.mahara.org/7228
Committed: https://git.mahara.org/mahara/mahara/commit/f1b0580d2ee525930b4b6cf3839cb5e63177e284
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f1b0580d2ee525930b4b6cf3839cb5e63177e284
Author: Robert Lyon <email address hidden>
Date: Fri Nov 4 13:43:50 2016 +1300

Bug 1639096: Fixing shared with group pagination

To test:
1) Create a group A and set it up to allow submissions
2) Get user A to make 12 pages and then share them with group A
3) Get user B to make 12 pages and then submit them all for assessment
to Group A

When we try to go to the next page for shared pages we get results for
submissions as well.

behatnotneeded

Change-Id: I3df34b2a3c66e01affca9753a42237e849fc4a12
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7230
Committed: https://git.mahara.org/mahara/mahara/commit/1e258f9ebbcca8d3662368fd5574275975a847d2
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1e258f9ebbcca8d3662368fd5574275975a847d2
Author: Robert Lyon <email address hidden>
Date: Mon Nov 7 08:01:13 2016 +1300

Bug 1639096: Fixing setting of $limit in all submissions ajax

The existing code was slightly wrong when compared to the other ajax
files in this dir.

Though probably wouldn't have caused an issue as the the ajax wouldn't
have been called if the block didn't allow submissions - so this fix
is to just tidy up the code.

behatnotneeded

Change-Id: Ia715b53379bde6abe43591c2ca36623be1b07b90
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7313

Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/7314

Reviewed: https://reviews.mahara.org/7312
Committed: https://git.mahara.org/mahara/mahara/commit/9c22891980a3a313cab5577cad41c02947483af7
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 9c22891980a3a313cab5577cad41c02947483af7
Author: Robert Lyon <email address hidden>
Date: Fri Nov 4 13:43:50 2016 +1300

Bug 1639096: Fixing shared with group pagination

To test:
1) Create a group A and set it up to allow submissions
2) Get user A to make 12 pages and then share them with group A
3) Get user B to make 12 pages and then submit them all for assessment
to Group A

When we try to go to the next page for shared pages we get results for
submissions as well.

behatnotneeded

Change-Id: I3df34b2a3c66e01affca9753a42237e849fc4a12
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit f1b0580d2ee525930b4b6cf3839cb5e63177e284)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7313
Committed: https://git.mahara.org/mahara/mahara/commit/dc932281ff52b983edd945056bc4ce60d8056fb7
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit dc932281ff52b983edd945056bc4ce60d8056fb7
Author: Robert Lyon <email address hidden>
Date: Fri Nov 4 13:43:50 2016 +1300

Bug 1639096: Fixing shared with group pagination

To test:
1) Create a group A and set it up to allow submissions
2) Get user A to make 12 pages and then share them with group A
3) Get user B to make 12 pages and then submit them all for assessment
to Group A

When we try to go to the next page for shared pages we get results for
submissions as well.

behatnotneeded

Change-Id: I3df34b2a3c66e01affca9753a42237e849fc4a12
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit f1b0580d2ee525930b4b6cf3839cb5e63177e284)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7314
Committed: https://git.mahara.org/mahara/mahara/commit/96eb99a5511d801dae56005cfd27c4f001cc824b
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 96eb99a5511d801dae56005cfd27c4f001cc824b
Author: Robert Lyon <email address hidden>
Date: Fri Nov 4 13:43:50 2016 +1300

Bug 1639096: Fixing shared with group pagination

To test:
1) Create a group A and set it up to allow submissions
2) Get user A to make 12 pages and then share them with group A
3) Get user B to make 12 pages and then submit them all for assessment
to Group A

When we try to go to the next page for shared pages we get results for
submissions as well.

behatnotneeded

Change-Id: I3df34b2a3c66e01affca9753a42237e849fc4a12
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit f1b0580d2ee525930b4b6cf3839cb5e63177e284)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers