Make core themes consistent in the way they are set up

Bug #1637371 reported by Kristina Hoeppner on 2016-10-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Wishlist
Pat

Bug Description

The core themes differ to some degree in how they have been created because they had to be created while we were still actively developing on the Bootstrap changes. Therefore, certain elements are implemented differently across themes, which makes it hard to keep them all updated and having the same styles etc.

Pat suggests to make things more consistent for these themes so it's also possible to inherit from every theme (currently, Ocean can't be inherited from).

This would also help make things easier for themers.

e.g. consolidate some variables (group navigation bar also works out of the box in subthemestarter).

Changed in mahara:
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/7273
Committed: https://git.mahara.org/mahara/mahara/commit/66d234c520a0f105c181e6656d0204d537dc578a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 66d234c520a0f105c181e6656d0204d537dc578a
Author: Pat Kira <email address hidden>
Date: Fri Nov 25 16:40:20 2016 +1300

Bug 1637371 - Consilidating raw theme colours

- Amend Ocean theme implementation similar to other theme so new theme
can inherit from it

- Ensure that all colour values in scss components are variables (except
those that are more specific)

- Remove select2.scss as it is now part of raw theme for theme-ability
- Also remove select2.css inclusion in PHP files
- Add scss version of select2 styles and remove existing one
(_select2.scss)
- Create _mahara-select.scss for style override

behatnotneeded: styling only

Change-Id: I624b55ce34dd19ad525ba250877780bfbc0251b5

Robert Lyon (robertl-9) on 2017-03-13
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2017-04-27
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers