Group members should not receive group membership request notifications

Bug #1637287 reported by Richard Schütz on 2016-10-27
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
16.10
High
Unassigned
17.04
High
Unassigned

Bug Description

Notifications about new group membership requests are also sent to normal group members, which leads to a lot of useless emails. Only group administrators should receive this type of notification.

This behaviour was first observed after upgrading to Mahara 16.10.0, thus seems to be a regression.

Richard Schütz (rschuetz) wrote :

This seems to be caused by the proposed fix for bug #1461331. Reverting the commit fixes the issue.

Robert Lyon (robertl-9) on 2016-11-07
Changed in mahara:
importance: Undecided → High
status: New → Confirmed
Robert Lyon (robertl-9) on 2016-11-07
Changed in mahara:
status: Confirmed → In Progress
Robert Lyon (robertl-9) wrote :

I've made a patch so that we can indicate exactly which users are to get the email by supplying user ids to GroupMessage to fine grain who gets the messages.

https://reviews.mahara.org/#/c/7234/

Robert Lyon (robertl-9) wrote :

Normally we can just pass in the roles but here we are wanting to translate the emails individually to the preferred language for the admin of the group.
In this way if a user viewing the site in Spanish can request an invite to a group where one group admin's preferred language is German and another group admin's preferred language is Spanish and they both get their emails in their preferred language.

Changed in mahara:
milestone: none → 17.04.0

Reviewed: https://reviews.mahara.org/7234
Committed: https://git.mahara.org/mahara/mahara/commit/e01256956614c8bb366bcc172168f98b2cb328e2
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e01256956614c8bb366bcc172168f98b2cb328e2
Author: Robert Lyon <email address hidden>
Date: Mon Nov 7 13:28:09 2016 +1300

Bug 1637287: Restrict the group membership request to admins only

Since we changed the message activity from 'maharamessage' to
'groupmessage' we need to restrict the users getting the message to
the admins.

Also update the group_invite_user() message to be a groupmessage as well

behatnotneeded

Change-Id: I0c4f94392c3a168b4a241f5c5ad3cce20547b934
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/7320
Committed: https://git.mahara.org/mahara/mahara/commit/0a9af2cba720d5992dc83243ca2806f35be917c8
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 0a9af2cba720d5992dc83243ca2806f35be917c8
Author: Robert Lyon <email address hidden>
Date: Mon Nov 7 13:28:09 2016 +1300

Bug 1637287: Restrict the group membership request to admins only

Since we changed the message activity from 'maharamessage' to
'groupmessage' we need to restrict the users getting the message to
the admins.

Also update the group_invite_user() message to be a groupmessage as well

behatnotneeded

Change-Id: I0c4f94392c3a168b4a241f5c5ad3cce20547b934
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit e01256956614c8bb366bcc172168f98b2cb328e2)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers