auth/saml/lib.php breaks PHP 5.4 compatability

Bug #1636866 reported by Kevin Rickis on 2016-10-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
16.10
High
Unassigned

Bug Description

Hi,

I'm installing Mahara 16.10.0 on a server running PHP 5.4.45.

Line 453 of auth/saml/lib.php breaks compatibility with PHP 5.4

        if (empty(get_config('memcacheservers')) && !extension_loaded('memcache')) {

Prior to 5.5 this should be something like

        $memcacheservers_config = get_config('memcacheservers');
        if (empty($memcacheservers_config) && !extension_loaded('memcache')) {...}

Either auth/saml/lib.php needs changed or the README.md needs updated to reflect that the required minimum version is now 5.5. I only spotted this as my development server still runs 5.4, mu live server is on 5.6.

Kevin

Robert Lyon (robertl-9) on 2016-10-26
Changed in mahara:
status: New → In Progress
milestone: none → 17.04.0
importance: Undecided → High
assignee: nobody → Robert Lyon (robertl-9)

Reviewed: https://reviews.mahara.org/7213
Committed: https://git.mahara.org/mahara/mahara/commit/86a52f49c8706b7c78ebcdccb3a0d3661e4a99c9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 86a52f49c8706b7c78ebcdccb3a0d3661e4a99c9
Author: Robert Lyon <email address hidden>
Date: Thu Oct 27 08:42:20 2016 +1300

Bug 1636866: Allowing the empty check of get_config() option

The pre php5.5 "Can't use method return value in write context" issue

behatnotneeded

Change-Id: Ie5f122d96eddb643b3931eac29e8367323611cf8
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/7223
Committed: https://git.mahara.org/mahara/mahara/commit/c86ff89f45f02f973362c7df41b943b512fb29e3
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit c86ff89f45f02f973362c7df41b943b512fb29e3
Author: Robert Lyon <email address hidden>
Date: Thu Oct 27 08:42:20 2016 +1300

Bug 1636866: Allowing the empty check of get_config() option

The pre php5.5 "Can't use method return value in write context" issue

behatnotneeded

Change-Id: Ie5f122d96eddb643b3931eac29e8367323611cf8
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 86a52f49c8706b7c78ebcdccb3a0d3661e4a99c9)

Robert Lyon (robertl-9) on 2016-11-01
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2017-04-27
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers