Set up a SmartEvidence framework in the admin interface

Bug #1635503 reported by Robert Lyon
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Rebecca Blundell

Bug Description

Currently (in 16.10) we can upload a .matrix file containing a Smart Evidence framework

But once it is uploaded we are unable to alter it via the web interface (only through the database).

What would be good is an admin interface that at least allowed for the editing of the field names and the re-ordering of evidence elements as well as adding new elements

A thing to take into account is should one be allowed to edit a Smart Evidence framework once it is already being used and if so what things are ok to edit at that point and what things can be edited before it is in use.

I'm thinking order and field values can be edited before it is in use.

Once someone is using it then the order / fields for current framework should be set - but maybe possible to add new standard elements to framework.

Also it would be good to have a 'copy framework' option to be able to duplicate a framework

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote : Re: Allow manipulation of SmartEvidence framework via admin interface

Related to that, Don suggested that we could have a stand-alone editor to create SmartEvidence frameworks outside of Mahara. That could potentially make it a simpler / more lightweight application than having it in Mahara and be used for other platforms maybe at some point as well. We could then also think of making frameworks available for others to download.

Such an editor wouldn't replace this wishlist item here. I just wanted to mention it so we keep it in mind when thinking about the requirements for the admin interface.

Changed in mahara:
status: New → Confirmed
summary: - Allow manipulation of smart evidence framework via admin interface
+ Allow manipulation of SmartEvidence framework via admin interface
Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

I've found a JSON editor library we could use for this
https://github.com/json-editor/json-editor

a few notes that I made:
- has no dependencies. It only needs a modern browser
- we can validate a JSON file in the editor we define
- we can define a custom validation
- there are many formats for the fields, including tinyMCE
- dependencies between the fields, we can make one field value depend on another's field value. Could be useful to define standards and standard elements.
- it provides buttons to add/remove/reorder items, this can be activated for each one or globally
- it supports different languages
- different sections of the JSO can be shown in different tabs

Changed in mahara:
assignee: nobody → Rebecca Blundell (rjb-dev)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9018

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9476

Revision history for this message
Rebecca Blundell (rjb-dev) wrote : Re: Allow manipulation of SmartEvidence framework via admin interface

JSON Editor - Initial test plan

Go to http://mahara/module/framework/frameworks.php

Click on Add framework
 - You see a form that corresponds to all the fields in a .matrix json file as described in https://manual.mahara.org/en/18.10/administration/smartevidence.html#smartevidence-admin 11.9.4
 - You can enter information into the form and when you press the Save button, it appears in the database.
 - If you follow the navigation to 'Upload', you can upload an existing .matrix json file

Edit and Copy dropdowns

If a framework is inactive and has not been used in a collection, it is able to be edited and should appear in the 'Edit saved framework' dropdown.
All saved frameworks should appear in the 'Copy existing framework' dropdown

Once you choose one of these option, the form should populate with the information from that framework.

If you choose from the 'Edit' dropdown, make changes and Save, the existing record for that framework should be updated.
If you choose from the 'Copy' dropdown, any changes will be added to a new framework and the existing one will remain the same.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Existing framework files can be found at https://seafile.catalyst.net.nz/d/c5a4876b06/ for upload.

Changed in mahara:
milestone: none → 19.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9603

Revision history for this message
Steven (stevens-q) wrote : Re: Allow manipulation of SmartEvidence framework via admin interface

Bug: All manually created Frameworks are not being displayed on frontend

Preconditions
1) 2 institutions exist - both have smart evidence enabled
2) The following smart evidence frameworks are loaded when Mahara installed
  a) Career Readiness = Active
  b) Ngā paerewa mō te umanga whakaakoranga = NOT Active
  c) Standards for the teaching profession = NOT Active
3) Framework created using editor - by copy existing framework
        a) some fields changed - see attached form for details
4) Framework saved and Active
5) Uploaded Example framework exists and is available to all Institutions and is Active

Expected Result: When creating a smart evidence collection - all frameworks for particular Institution will be available (this depends on which Institution user is in)

Actual result: When creating a smart evidence collection - only the Active pre-loaded Frameworks and the uploaded frameworks are available to be selected when creating collection

Revision history for this message
Steven (stevens-q) wrote :
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Frameworks that are set to not active should not be available to anyone. I'm not sure whether the reported issue is an actual issue. Will need to see it on your screen, Steven.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9687

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9476
Committed: https://git.mahara.org/mahara/mahara/commit/5accb2c9d1259005249248d5cb4f2fa8acba97b5
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 5accb2c9d1259005249248d5cb4f2fa8acba97b5
Author: Rebecca Blundell <email address hidden>
Date: Fri Jan 25 15:09:41 2019 +1300

Bug 1635503: Custom changes to json editor

behatnotneeded

Change-Id: I6c6d5642290d558dac436572061bd73ce436067f

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9603
Committed: https://git.mahara.org/mahara/mahara/commit/fc32eedbe903b72a2711de37629eed8fd909fcfd
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit fc32eedbe903b72a2711de37629eed8fd909fcfd
Author: Rebecca Blundell <email address hidden>
Date: Wed Feb 27 14:14:43 2019 +1300

Bug 1635503: Styling changes to json editor

Changes needed after bootstrap 4 merged
Changes to default styling of JSON editor that we want to customise

behatnotneeded

Change-Id: I3358d92c64056e02ad4e976fa79b7f73d3cedb54

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9687
Committed: https://git.mahara.org/mahara/mahara/commit/38d563774db2bfeaa556bd7403677e7317b04250
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 38d563774db2bfeaa556bd7403677e7317b04250
Author: Rebecca Blundell <email address hidden>
Date: Thu Jul 19 13:54:48 2018 +1200

Bug 1635503: Add JSON editor for SmartEvidence

This adds a visual JSON editor for SmartEvidence
frameworks allowing site administrators to create
such frameworks more easily by copying and pasting
rather than needing to know the JSON file syntax.

behatnotneeded

Change-Id: Ief74375a6c5d23ab05e12f08d07dd3209e89c948

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9700

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9748

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9757

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9758

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9757
Committed: https://git.mahara.org/mahara/mahara/commit/93b77a0e5552ea2094ef514953c7396deb2d1018
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 93b77a0e5552ea2094ef514953c7396deb2d1018
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Apr 12 13:26:50 2019 +1200

Bug 1635503: Add third-level nav to management screen of a framework
(Competency status switches)

behatnotneeded

Change-Id: I5a740057ddc6ccce3160aa7fa63e587fdba5b5f8

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9760

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9760
Committed: https://git.mahara.org/mahara/mahara/commit/df1151a2ddf5fa9ddd40c8b721c9608d7a2979f9
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit df1151a2ddf5fa9ddd40c8b721c9608d7a2979f9
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Apr 12 13:26:50 2019 +1200

Bug 1635503: Add third-level nav to management screen of a framework
(Competency status switches)

behatnotneeded

Change-Id: I5a740057ddc6ccce3160aa7fa63e587fdba5b5f8
(cherry picked from commit 93b77a0e5552ea2094ef514953c7396deb2d1018)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9769

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9770

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9773

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9778

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9779

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9780

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9758
Committed: https://git.mahara.org/mahara/mahara/commit/4efd271214aa86e58504fde77651e73f78817355
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4efd271214aa86e58504fde77651e73f78817355
Author: Rebecca Blundell <email address hidden>
Date: Fri Apr 12 15:03:17 2019 +1200

Bug 1635503: Populate element id on parent id change

Change-Id: Iff716400fbaeac452241d02f51ad751f8a8a0538

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9773
Committed: https://git.mahara.org/mahara/mahara/commit/482a32cd4db9660531b31bdbfff3a2463830d00b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 482a32cd4db9660531b31bdbfff3a2463830d00b
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 15 16:59:04 2019 +1200

Bug 1635503: Adding delete button handlers to update global vars

+ removed se_count variable not needed.
We can use parent_array.length instead

behatnotneeded

Change-Id: I6aab1c69adad715300f9d2fd03a979a180c0e665

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9770
Committed: https://git.mahara.org/mahara/mahara/commit/ffed11810d1df99d681e87c4b7aad727afecaa24
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ffed11810d1df99d681e87c4b7aad727afecaa24
Author: Robert Lyon <email address hidden>
Date: Mon Apr 15 15:17:20 2019 +1200

Bug 1635503: Adjust the copy/edit selectors

So that we pass in the key as well as value to the template
then we can simplify the javascript around fetching the correct matrix

behatnotneeded

Change-Id: If4d2d47837de46fbbc5f6ecf6ec955687a264fa0
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9700
Committed: https://git.mahara.org/mahara/mahara/commit/c142392e2a45f89f8f47fad8c729d9955dfc5c91
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c142392e2a45f89f8f47fad8c729d9955dfc5c91
Author: Rebecca Blundell <email address hidden>
Date: Wed Apr 3 12:51:27 2019 +1300

Bug 1635503: JSON editor fixes for 19.04

-refactor variables to be more sensible
-add hidden watched pid field to the schema, remove stdid field
-functions to populate parentid dropdown

behatnotneeded
Change-Id: I5df071beeb9fa505a575cca5b6f8cb574bff06b4

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9748
Committed: https://git.mahara.org/mahara/mahara/commit/dd89f432afa29afaebf15e01f5ce176282e53fb4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit dd89f432afa29afaebf15e01f5ce176282e53fb4
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Apr 11 17:02:55 2019 +1200

Bug 1635503: JSON editor- add checks for form change

+ scrolling to the top of the page after saving the form

behatnotneeded

Change-Id: I239ec03c4ebf6319379ce61a7069f08951ca11de

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9781

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9781
Committed: https://git.mahara.org/mahara/mahara/commit/a0f347f03aa966edc03235ff4e2a58ff3e30da63
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit a0f347f03aa966edc03235ff4e2a58ff3e30da63
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Apr 11 17:02:55 2019 +1200

Bug 1635503: JSON editor- add checks for form change

+ scrolling to the top of the page after saving the form

behatnotneeded

Change-Id: I239ec03c4ebf6319379ce61a7069f08951ca11de
(cherry picked from commit dd89f432afa29afaebf15e01f5ce176282e53fb4)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9782

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9782
Committed: https://git.mahara.org/mahara/mahara/commit/efcfb4d3e30cdc5ebaf0616b31f102cf70a287a3
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit efcfb4d3e30cdc5ebaf0616b31f102cf70a287a3
Author: Robert Lyon <email address hidden>
Date: Mon Apr 15 15:17:20 2019 +1200

Bug 1635503: Adjust the copy/edit selectors

So that we pass in the key as well as value to the template
then we can simplify the javascript around fetching the correct matrix

behatnotneeded

Change-Id: If4d2d47837de46fbbc5f6ecf6ec955687a264fa0
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit ffed11810d1df99d681e87c4b7aad727afecaa24)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9783

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9783
Committed: https://git.mahara.org/mahara/mahara/commit/ca048fa9e655a10ea1619cd85d6c7a8fb417c4ef
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit ca048fa9e655a10ea1619cd85d6c7a8fb417c4ef
Author: Rebecca Blundell <email address hidden>
Date: Wed Apr 3 12:51:27 2019 +1300

Bug 1635503: JSON editor fixes for 19.04

-refactor variables to be more sensible
-add hidden watched pid field to the schema, remove stdid field
-functions to populate parentid dropdown

behatnotneeded
Change-Id: I5df071beeb9fa505a575cca5b6f8cb574bff06b4
(cherry picked from commit c142392e2a45f89f8f47fad8c729d9955dfc5c91)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9784

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9784
Committed: https://git.mahara.org/mahara/mahara/commit/af41d41b9282acfce4bd12b4ac5aa86e0f6e8311
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit af41d41b9282acfce4bd12b4ac5aa86e0f6e8311
Author: Rebecca Blundell <email address hidden>
Date: Fri Apr 12 15:03:17 2019 +1200

Bug 1635503: Populate element id on parent id change

Change-Id: Iff716400fbaeac452241d02f51ad751f8a8a0538
(cherry picked from commit 4efd271214aa86e58504fde77651e73f78817355)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9785

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9785
Committed: https://git.mahara.org/mahara/mahara/commit/834434e61e44f0a6e0f4311e2e3b03c2e51b9401
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 834434e61e44f0a6e0f4311e2e3b03c2e51b9401
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 15 16:59:04 2019 +1200

Bug 1635503: Adding delete button handlers to update global vars

+ removed se_count variable not needed.
We can use parent_array.length instead

behatnotneeded

Change-Id: I6aab1c69adad715300f9d2fd03a979a180c0e665
(cherry picked from commit 482a32cd4db9660531b31bdbfff3a2463830d00b)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9786

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9791

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9793

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9769
Committed: https://git.mahara.org/mahara/mahara/commit/1a112863315d6699c76dece2e1eb90f0666a00f5
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 1a112863315d6699c76dece2e1eb90f0666a00f5
Author: Rebecca Blundell <email address hidden>
Date: Mon Apr 15 15:18:59 2019 +1200

Bug 1635503: tidy up editor.js

fixed comments
made file more readable

behatnotneeded

Change-Id: I3dd1cc3ad3205604574e4fd4ba76ac0450559ff7

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9779
Committed: https://git.mahara.org/mahara/mahara/commit/e5cef702f723af4473de06a1a759b08de5f3a1f9
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit e5cef702f723af4473de06a1a759b08de5f3a1f9
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Apr 16 13:14:46 2019 +1200

Bug 1635503: improving selectors when adding ids to html elements

behatnotneeded

Change-Id: I84f8a72c38888d1b2a723f1940e96bf79a3d8e30

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9794

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9794
Committed: https://git.mahara.org/mahara/mahara/commit/23c5103e08be68621710b9abcdbf54d94602b74d
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 23c5103e08be68621710b9abcdbf54d94602b74d
Author: Rebecca Blundell <email address hidden>
Date: Mon Apr 15 15:18:59 2019 +1200

Bug 1635503: tidy up editor.js

fixed comments
made file more readable

behatnotneeded

Change-Id: I3dd1cc3ad3205604574e4fd4ba76ac0450559ff7
(cherry picked from commit 1a112863315d6699c76dece2e1eb90f0666a00f5)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9795

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9795
Committed: https://git.mahara.org/mahara/mahara/commit/544d4d0c90a733b486f6da800445ac49202f0108
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 544d4d0c90a733b486f6da800445ac49202f0108
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Apr 16 13:14:46 2019 +1200

Bug 1635503: improving selectors when adding ids to html elements

behatnotneeded

Change-Id: I84f8a72c38888d1b2a723f1940e96bf79a3d8e30
(cherry picked from commit e5cef702f723af4473de06a1a759b08de5f3a1f9)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9804

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9807

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9808

summary: - Allow manipulation of SmartEvidence framework via admin interface
+ Set up a SmartEvidence framework in the admin interface
tags: added: nominatedfeature
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9819

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9828

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9808
Committed: https://git.mahara.org/mahara/mahara/commit/762cdd9a2c22738a81431b1fbde1108c1893f3bf
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 762cdd9a2c22738a81431b1fbde1108c1893f3bf
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Apr 18 18:04:54 2019 +1200

Bug 1635503: Set standard id when selecting parent id for an element

behatnotneeded

Change-Id: I320e0ea1ff8bc14772aab47f006258e5a98bba55

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9791
Committed: https://git.mahara.org/mahara/mahara/commit/45239a3a5d1b31c08929e9b98629a47fb7eaf14d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 45239a3a5d1b31c08929e9b98629a47fb7eaf14d
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 17 14:50:43 2019 +1200

Bug 1635503: Removing standard_count variable

+ adding delete handlers for Standards section

behatnotneeded

Change-Id: I5aef31f2507d758fa645373099d7346cd28f2536

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9804
Committed: https://git.mahara.org/mahara/mahara/commit/4d1b9bd442d8e0b62837bd1a2c4df57bf345312d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4d1b9bd442d8e0b62837bd1a2c4df57bf345312d
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Apr 18 10:44:48 2019 +1200

Bug 1635503: Duplicated elements when fetching framework

behatnotneeded

Change-Id: I95396afd76fd42efd4f852d74165b3b195dafac7

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9793
Committed: https://git.mahara.org/mahara/mahara/commit/4ebbbb14d362e8c9dddfbc7110c6aa1852286f77
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4ebbbb14d362e8c9dddfbc7110c6aa1852286f77
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 17 16:27:17 2019 +1200

Bug 1635503: Setting description style after adding elements

behatnotneeded

Change-Id: If38298a6767c98e8d0aca08de8865f399bece037

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9807
Committed: https://git.mahara.org/mahara/mahara/commit/3537b4165851e79861a263ed0a7b53db1534638a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3537b4165851e79861a263ed0a7b53db1534638a
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Apr 18 15:22:07 2019 +1200

Bug 1635503: DB ids when saving framework

behatnotneeded

Change-Id: I0da0f1a960d07fd0671ad4ffa0379e0e7ddec63b

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9786
Committed: https://git.mahara.org/mahara/mahara/commit/7500aff7009bcc381920a90422521e6590489112
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7500aff7009bcc381920a90422521e6590489112
Author: Rebecca Blundell <email address hidden>
Date: Tue Apr 16 17:16:13 2019 +1200

Bug 1635503: Fix some issues on saving SmartEvidence framework via editor

-error no std
-error parent is undefined
-fix eid increment
-add hidden parent field so editor knows parent is not undef when set

behatnotneeded

Change-Id: Ic3b9625c29f75ffba91d5a2fb933eed3f8508544

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9780
Committed: https://git.mahara.org/mahara/mahara/commit/833b23dbe6fba338dc4926434d54599539cf8736
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 833b23dbe6fba338dc4926434d54599539cf8736
Author: Rebecca Blundell <email address hidden>
Date: Tue Apr 16 14:50:27 2019 +1200

Bug 1635503: Small fixes to SmartEvidence editor

behatnotneeded

Change-Id: Ide3c89454be8a8a7e70be5c6aae27b7181277124

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9819
Committed: https://git.mahara.org/mahara/mahara/commit/a5e3533f9202963a4d3b67274d5d7ad945eff7df
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a5e3533f9202963a4d3b67274d5d7ad945eff7df
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Apr 23 11:53:36 2019 +1200

Bug 1635503: JSON editor - saving a copy only once

behatnotneeded

Change-Id: If4fe5c1eba980312bc46be03c3a54adf87f84de1

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9829

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9829
Committed: https://git.mahara.org/mahara/mahara/commit/e684f3642f40ccaa4b2f67fee11dfeecd00987a7
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit e684f3642f40ccaa4b2f67fee11dfeecd00987a7
Author: Rebecca Blundell <email address hidden>
Date: Tue Apr 16 14:50:27 2019 +1200

Bug 1635503: Small fixes to SmartEvidence editor

behatnotneeded

Change-Id: Ide3c89454be8a8a7e70be5c6aae27b7181277124
(cherry picked from commit 833b23dbe6fba338dc4926434d54599539cf8736)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9830

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9830
Committed: https://git.mahara.org/mahara/mahara/commit/8e0a6fed9cedfb3118c75a0684a8ff6017fc8d2e
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 8e0a6fed9cedfb3118c75a0684a8ff6017fc8d2e
Author: Rebecca Blundell <email address hidden>
Date: Tue Apr 16 17:16:13 2019 +1200

Bug 1635503: Fix some issues on saving SmartEvidence framework via editor

-error no std
-error parent is undefined
-fix eid increment
-add hidden parent field so editor knows parent is not undef when set

behatnotneeded

Change-Id: Ic3b9625c29f75ffba91d5a2fb933eed3f8508544
(cherry picked from commit 7500aff7009bcc381920a90422521e6590489112)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9831

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9831
Committed: https://git.mahara.org/mahara/mahara/commit/b259431e53787910c8bf799b694953b52981b223
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit b259431e53787910c8bf799b694953b52981b223
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 17 14:50:43 2019 +1200

Bug 1635503: Removing standard_count variable

+ adding delete handlers for Standards section

behatnotneeded

Change-Id: I5aef31f2507d758fa645373099d7346cd28f2536
(cherry picked from commit 45239a3a5d1b31c08929e9b98629a47fb7eaf14d)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9832

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9832
Committed: https://git.mahara.org/mahara/mahara/commit/d6fb0669d47d82f73a26a0f94259898dcba2fd8b
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit d6fb0669d47d82f73a26a0f94259898dcba2fd8b
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 17 16:27:17 2019 +1200

Bug 1635503: Setting description style after adding elements

behatnotneeded

Change-Id: If38298a6767c98e8d0aca08de8865f399bece037
(cherry picked from commit 4ebbbb14d362e8c9dddfbc7110c6aa1852286f77)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9833

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9833
Committed: https://git.mahara.org/mahara/mahara/commit/9f4e4f3d503995732d81a88bf64b3444ad33528e
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 9f4e4f3d503995732d81a88bf64b3444ad33528e
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Apr 18 10:44:48 2019 +1200

Bug 1635503: Duplicated elements when fetching framework

behatnotneeded

Change-Id: I95396afd76fd42efd4f852d74165b3b195dafac7
(cherry picked from commit 4d1b9bd442d8e0b62837bd1a2c4df57bf345312d)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9834

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9834
Committed: https://git.mahara.org/mahara/mahara/commit/7f8e18ff7a9f49574114f7c1af66c48993007cd8
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 7f8e18ff7a9f49574114f7c1af66c48993007cd8
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Apr 18 15:22:07 2019 +1200

Bug 1635503: DB ids when saving framework

behatnotneeded

Change-Id: I0da0f1a960d07fd0671ad4ffa0379e0e7ddec63b
(cherry picked from commit 3537b4165851e79861a263ed0a7b53db1534638a)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9835

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9835
Committed: https://git.mahara.org/mahara/mahara/commit/36a975e97d67f643ebdd9f8108576912abd49cd5
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 36a975e97d67f643ebdd9f8108576912abd49cd5
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Apr 18 18:04:54 2019 +1200

Bug 1635503: Set standard id when selecting parent id for an element

behatnotneeded

Change-Id: I320e0ea1ff8bc14772aab47f006258e5a98bba55
(cherry picked from commit 762cdd9a2c22738a81431b1fbde1108c1893f3bf)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9836

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9836
Committed: https://git.mahara.org/mahara/mahara/commit/0bdac5efc942088e966982ff1b9bc9487f6a26a6
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 0bdac5efc942088e966982ff1b9bc9487f6a26a6
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Apr 23 11:53:36 2019 +1200

Bug 1635503: JSON editor - saving a copy only once

behatnotneeded

Change-Id: If4fe5c1eba980312bc46be03c3a54adf87f84de1
(cherry picked from commit a5e3533f9202963a4d3b67274d5d7ad945eff7df)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9828
Committed: https://git.mahara.org/mahara/mahara/commit/fac56b68bdd977654b0ec3c8fb2ce37518858a35
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit fac56b68bdd977654b0ec3c8fb2ce37518858a35
Author: Robert Lyon <email address hidden>
Date: Wed Apr 24 07:29:59 2019 +1200

Bug 1635503: Code tidying up - indentation / comments

behatnotneeded

Change-Id: Ie11eca7384a9bda6d23de13f3b29a7c334ba378b
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9840

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9840
Committed: https://git.mahara.org/mahara/mahara/commit/197bad8b1b217c25d358eff01f1988ddae13b577
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 197bad8b1b217c25d358eff01f1988ddae13b577
Author: Robert Lyon <email address hidden>
Date: Wed Apr 24 07:29:59 2019 +1200

Bug 1635503: Code tidying up - indentation / comments

behatnotneeded

Change-Id: Ie11eca7384a9bda6d23de13f3b29a7c334ba378b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit fac56b68bdd977654b0ec3c8fb2ce37518858a35)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9891

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9893

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/9896

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9891
Committed: https://git.mahara.org/mahara/mahara/commit/3c0cfa2e6ebff96b570ef0974c69f4a92cd66c3a
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 3c0cfa2e6ebff96b570ef0974c69f4a92cd66c3a
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 29 10:48:34 2019 +1200

Bug 1635503: SE editor - show shortname for standard elements in matrix page

behatnotneeded

Change-Id: I46e2a59e3affab89057fea0e64a8d55c3b5dddc1

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9901

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9901
Committed: https://git.mahara.org/mahara/mahara/commit/bbad9b7298e77e258f8aa839117e12690b6f121c
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit bbad9b7298e77e258f8aa839117e12690b6f121c
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 29 10:48:34 2019 +1200

Bug 1635503: SE editor - show shortname for standard elements in matrix page

behatnotneeded

Change-Id: I46e2a59e3affab89057fea0e64a8d55c3b5dddc1
(cherry picked from commit 3c0cfa2e6ebff96b570ef0974c69f4a92cd66c3a)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9893
Committed: https://git.mahara.org/mahara/mahara/commit/b91aad3842c8a8a25607ae514bb1ad05cd3deb6f
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit b91aad3842c8a8a25607ae514bb1ad05cd3deb6f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 29 12:27:52 2019 +1200

Bug 1635503: SE editor- stop fetching a framework when clearing the edit/copy dropdowns

+ removed "upload" variable not being used

behatnotneeded

Change-Id: I8622538bc1ad1ca91ba8a8140742a086bfa11b1e

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9908

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9896
Committed: https://git.mahara.org/mahara/mahara/commit/36c330fb4bb398c6fd035423f2e7917a7ae850d0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 36c330fb4bb398c6fd035423f2e7917a7ae850d0
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 29 15:22:08 2019 +1200

Bug 1635503: SE editor- get correct index value when loading framework

- to know if we already loaded element 1.1 or not
(otherwise, for a matrix with only one element for the first standard,
the 1.1 get deleted)
- also removed an unnecessary line

behatnotneeded

Change-Id: I8c7ab84e3ce4794823069593547f0e33647227d1

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9909

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9908
Committed: https://git.mahara.org/mahara/mahara/commit/717a3191a7870292bb29cb097fd70cf3be6f37d4
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 717a3191a7870292bb29cb097fd70cf3be6f37d4
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 29 12:27:52 2019 +1200

Bug 1635503: SE editor- stop fetching a framework when clearing the edit/copy dropdowns

+ removed "upload" variable not being used

behatnotneeded

Change-Id: I8622538bc1ad1ca91ba8a8140742a086bfa11b1e
(cherry picked from commit b91aad3842c8a8a25607ae514bb1ad05cd3deb6f)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/9909
Committed: https://git.mahara.org/mahara/mahara/commit/ce0fa0d31719cc86c768fa01a2b5d73948776ba9
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit ce0fa0d31719cc86c768fa01a2b5d73948776ba9
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Apr 29 15:22:08 2019 +1200

Bug 1635503: SE editor- get correct index value when loading framework

- to know if we already loaded element 1.1 or not
(otherwise, for a matrix with only one element for the first standard,
the 1.1 get deleted)
- also removed an unnecessary line

behatnotneeded

Change-Id: I8c7ab84e3ce4794823069593547f0e33647227d1
(cherry picked from commit 36c330fb4bb398c6fd035423f2e7917a7ae850d0)

Changed in mahara:
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11583

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers