Unable to decline email validation in mysql

Bug #1634702 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned

Bug Description

Reported by community member

https://mahara.org/interaction/forum/topic.php?id=7742&offset=0&limit=10#post31146

In the artefact_internal_profile_email we have a column called 'key' which turns out to be a reserved word in MySQL - and there is an sql query with WHERE key=? in it.

We will need to wrap the 'key' in double quotes

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7168

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7168
Committed: https://git.mahara.org/mahara/mahara/commit/f70bda97c54d0736cc45b78cd0000bedfd55574f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f70bda97c54d0736cc45b78cd0000bedfd55574f
Author: Robert Lyon <email address hidden>
Date: Wed Oct 19 13:05:13 2016 +1300

Bug 1634702: Need to respect the sql keyword 'key' in MySQL

We need to make it "key" = ?

behatnotneeded

Change-Id: Ib9da4bb82e32cf1ba02079cd7d62236bf2fc3b94
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7181

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7181
Committed: https://git.mahara.org/mahara/mahara/commit/66e7c5e4f7688c101b321e93de9c7d4ac876056b
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 66e7c5e4f7688c101b321e93de9c7d4ac876056b
Author: Robert Lyon <email address hidden>
Date: Wed Oct 19 13:05:13 2016 +1300

Bug 1634702: Need to respect the sql keyword 'key' in MySQL

We need to make it "key" = ?

behatnotneeded

Change-Id: Ib9da4bb82e32cf1ba02079cd7d62236bf2fc3b94
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit f70bda97c54d0736cc45b78cd0000bedfd55574f)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers