Error messages when on web services logs

Bug #1633808 reported by Kristina Hoeppner on 2016-10-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon

Bug Description

Mahara 16.10dev

When I visit the "Logs" page of the web services /webservice/admin/webservicelogs.php and have multiple institutions set up, I get:

[WAR] 5c (webservice/admin/webservicessearchlib.php:80) Undefined variable: institutions
Call stack (most recent first):

    log_message("Undefined variable: institutions", 8, true, true, "/home/kristina/code/1610stable/htdocs/webservice/a...", 80) at /home/kristina/code/1610stable/htdocs/lib/errors.php:521
    error(8, "Undefined variable: institutions", "/home/kristina/code/1610stable/htdocs/webservice/a...", 80, array(size 10)) at /home/kristina/code/1610stable/htdocs/webservice/admin/webservicessearchlib.php:80
    build_webservice_log_search_results(object(stdClass)) at /home/kristina/code/1610stable/htdocs/webservice/admin/webservicelogs.php:53

Robert Lyon (robertl-9) on 2016-10-16
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Robert Lyon (robertl-9)
Robert Lyon (robertl-9) on 2016-10-20
Changed in mahara:
milestone: 16.10.0 → 16.10.1
Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
milestone: 16.10.1 → 17.04.0

Reviewed: https://reviews.mahara.org/7122
Committed: https://git.mahara.org/mahara/mahara/commit/4376ab2b19e56393f6c21ad43d3d2f909404492a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4376ab2b19e56393f6c21ad43d3d2f909404492a
Author: Robert Lyon <email address hidden>
Date: Fri Oct 14 15:24:04 2016 +1300

Bug 1633808: Webservices logs form display institution field

Was not quite working before.

Things also fixed (or partially fixed)
1) The webservice logs page searching for function name to filter by
- before the ajax was wanting to paginate by 5 and select2 expected 10
results so the more search results was not working

2) The error returned on the testclient page when there was an error
with a field didn't display which field it was.

3) Display on testclient page a file upload filed if type is PARAM_FILE
- The actual testing of file upload is not working yet but it wasn't
working before either but this is a step in the right direction

4) The wsdocs page was displaying 'REQUIRED' for the VALUE_DEFAULT
fields rather than the VALUE_REQUIRED fields.

behatnotneeded

Change-Id: Ia00beeb6d48fa3019984f2e0f7605fbb097edffd
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2017-02-15
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2017-04-27
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers