Allow the js lang strings to have their section set when doing variable replacement

Bug #1626281 reported by Robert Lyon on 2016-09-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Robert Lyon

Bug Description

Currently when we have a js string, say string.nrrows='%s rows' and we call it with get_string('nrrows', 4) - but we should call it with get_string('nrrows', 'view', 4) to indicate that this string is from the 'view' lang file.

I'll make the change so that the 'section' can be passed in as well so that in the future we can decide which section's lang string to use rather than currently having them be all unique.

Reviewed: https://reviews.mahara.org/6995
Committed: https://git.mahara.org/mahara/mahara/commit/75316569320985ece0d5df5d6840e7fda3762a45
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 75316569320985ece0d5df5d6840e7fda3762a45
Author: Robert Lyon <email address hidden>
Date: Thu Sep 22 09:16:20 2016 +1200

Bug 1626281: Pass the 'section' for js lang strings for better debugging.

@TODO: Allow the js lang strings be picked based on on the section
supplied so that name/section make them unique rather than just name

behatnotneeded - existing test will be sufficient

Change-Id: Ie64725702527b7fd9a08749816ea1fd084e95a2d
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/7008
Committed: https://git.mahara.org/mahara/mahara/commit/b91f4f67594e22f2007eb64cacbeee475a482584
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit b91f4f67594e22f2007eb64cacbeee475a482584
Author: Robert Lyon <email address hidden>
Date: Thu Sep 22 09:16:20 2016 +1200

Bug 1626281: Pass the 'section' for js lang strings for better debugging.

@TODO: Allow the js lang strings be picked based on on the section
supplied so that name/section make them unique rather than just name

behatnotneeded - existing test will be sufficient

Change-Id: Ie64725702527b7fd9a08749816ea1fd084e95a2d
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 75316569320985ece0d5df5d6840e7fda3762a45)

Robert Lyon (robertl-9) on 2016-09-23
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2017-04-27
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers