Can not add groups via CSV when shortname is not relied on displayname

[Son Nguyen]

version: master(16.10)

I got the following message when adding groups via CSV

Mahara: Site unavailable
Something in the way you're interacting with Mahara is causing an error.
Details if any, follow:

group_create: The supplied shortname 'gc' is already taken. This shortname 'groupc' is available.

The content of my CSV file:
shortname,displayname,roles
"gc","Group C","standard"

I have to change the shortname to 'groupc' to make it work.
Is it the new behaviour?

[Robert Lyon (robertl-9)]

in lib/group.php line 357

    if (!empty($data['shortname'])) {
        // make sure it is unique and is correct length
        $shortname = group_generate_shortname($data['name']);
        // If we want to retain the supplied shortname we need to make sure it can be done
        if (!empty($data['retainshortname'])) {
            if ($shortname != $data['shortname']) {

The
   $shortname = group_generate_shortname($data['name']);
should be
   $shortname = group_generate_shortname($data['shortname']);

So that we compare supplied shortname with valid one - which should be the same unless the supplied string contains invalid chars or the valid one is different because the supplied one is taken

[Son Nguyen (ngson2000)]

It works fine now. Thank for your explanation.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/6844

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/6844
Committed: https://git.mahara.org/mahara/mahara/commit/258273c4209411d51814bd39f4251ea144e843eb
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 258273c4209411d51814bd39f4251ea144e843eb
Author: Robert Lyon <email address hidden>
Date: Tue Aug 16 15:00:14 2016 +1200

Bug 1613503: Validate the shortname generated from provided shortname in CSV

not from displayname

behatnotneeded

Change-Id: If7134f6b97031fc848684b053795a02504b27316