Accessibility: Search text Placeholder goes away after tabbing into field

Bug #1605067 reported by Ghada El-Zoghbi on 2016-07-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Ghada El-Zoghbi
15.04
Medium
Unassigned
15.10
Medium
Unassigned
16.04
Medium
Unassigned
16.10
Medium
Ghada El-Zoghbi

Bug Description

Mahara: 16.04.2
DB: Postgres
Browser: Firefox
OS: Linux

The place holder text 'Search' in the site search field is removed after the user first tabs into the field. It is left empty thereafter.

For accessibility, the 'Search' text should be replaced again after the user tabs out of the field and they have not entered any text.

Changed in mahara:
assignee: nobody → Ghada El-Zoghbi (ghada-z)
tags: added: accessibility
Changed in mahara:
milestone: none → 16.10.0
importance: Undecided → Medium
status: New → In Progress

Reviewed: https://reviews.mahara.org/6739
Committed: https://git.mahara.org/mahara/mahara/commit/d48226c72a96c4da6e04f394396e357915cb9c33
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit d48226c72a96c4da6e04f394396e357915cb9c33
Author: Ghada El-Zoghbi <email address hidden>
Date: Thu Jul 21 16:21:34 2016 +1000

bug#1605067: improve accessibility by adding text placeholders for:

1. search text at the top menu
2. search text for users
3. search text for elasticsearch
4. search text for institutions

Thus, eliminating the need for the emptyonfocus class and its
related jquery code to hide the default text.

behatnotneeded

Change-Id: I57b9fcac4f9fd758b7048b8567101f28dcc48cff

Aaron Wells (u-aaronw) wrote :

We were using custom Javascript to fill in the placeholder text in empty text fields and clear it away when the user tabbed into it.

Ghada's patch switches us to using the HTML5 standard "placeholder" attribute, which works in all of our supported browsers: http://caniuse.com/#feat=input-placeholder

summary: - Search text Placeholder
+ Accessibility: Search text Placeholder goes away after tabbing into
+ field
Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6760

Mahara Bot (dev-mahara) wrote :

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6761

Reviewed: https://reviews.mahara.org/6761
Committed: https://git.mahara.org/mahara/mahara/commit/2c6ae585b2f138ffc3ae43cd634ad3dabdb8062a
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.04_STABLE

commit 2c6ae585b2f138ffc3ae43cd634ad3dabdb8062a
Author: Ghada El-Zoghbi <email address hidden>
Date: Thu Jul 21 16:21:34 2016 +1000

bug#1605067: improve accessibility by adding text placeholders for:

1. search text at the top menu
2. search text for users
3. search text for elasticsearch
4. search text for institutions

Thus, eliminating the need for the emptyonfocus class and its
related jquery code to hide the default text.

behatnotneeded

Change-Id: I57b9fcac4f9fd758b7048b8567101f28dcc48cff
(cherry picked from commit d48226c72a96c4da6e04f394396e357915cb9c33)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6760
Committed: https://git.mahara.org/mahara/mahara/commit/4e4920ae349bb0c42dfde3a4448fefbafe05dc3a
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 4e4920ae349bb0c42dfde3a4448fefbafe05dc3a
Author: Ghada El-Zoghbi <email address hidden>
Date: Thu Jul 21 16:21:34 2016 +1000

bug#1605067: improve accessibility by adding text placeholders for:

1. search text at the top menu
2. search text for users
3. search text for elasticsearch
4. search text for institutions

Thus, eliminating the need for the emptyonfocus class and its
related jquery code to hide the default text.

behatnotneeded

Change-Id: I57b9fcac4f9fd758b7048b8567101f28dcc48cff
(cherry picked from commit d48226c72a96c4da6e04f394396e357915cb9c33)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6759
Committed: https://git.mahara.org/mahara/mahara/commit/6ac8958bb7aa777b5d904e0b99e5314e615f458a
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 6ac8958bb7aa777b5d904e0b99e5314e615f458a
Author: Ghada El-Zoghbi <email address hidden>
Date: Thu Jul 21 16:21:34 2016 +1000

bug#1605067: improve accessibility by adding text placeholders for:

1. search text at the top menu
2. search text for users
3. search text for elasticsearch
4. search text for institutions

Thus, eliminating the need for the emptyonfocus class and its
related jquery code to hide the default text.

behatnotneeded

Change-Id: I57b9fcac4f9fd758b7048b8567101f28dcc48cff
(cherry picked from commit d48226c72a96c4da6e04f394396e357915cb9c33)

Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
milestone: 16.10.0 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers