Licenses: Once you've selected a license, you can't go back to "None"

[Aaron Wells]

While testing out Bug 1279526, I noticed that you can't change an uploaded file from a particular license to "No License". This may have been by design, with the idea that "No License" was a temporary thing until you pick a license. But with Bug 1279526 we're changing the wording of "No License" to make it clear that if you're not choosing a particular license, then the default copyright rules apply, so it becomes more necessary to be able to switch to that.

To replicate:

1. Go to "Administration -> Configure Site -> General Settings", and enable "License metadata"

2. Go to "Content -> Files" and upload a file.

3. Once the file is uploaded, click the pencil "edit" button to open its editing form. It should be at "No license" or the equivalent. Change it to "Creative Commons Attribution 4.0"

4. Click "Save changes"

5. Now click the pencil "edit" button again. Change the License back to "No license" or the equivalent.

6. Again click "Save changes"

7. Again click the pencil "edit" button.

Expected result: You see "No license" or the equivalent as the license selection.

Actual result: You see "Creative Commons Attribution 4.0" as the license selection.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/6725

[Kristina Hoeppner (kris-hoeppner)]

There is another scenario to test with the patch:

1. Set up an institution and select "Copyright"
Expected result now with the patch: You can select it.
Actual result: You can't select it.

now continuing with not having been able to choose "Copyright" as institution license but just a CC license:

2. Log in as a user of that institution.
3. Go to your account settings and change your default license to "Copyright".
Expected result: You can see "Copyright" and select it.
Actual result: "Copyright" is not available as option.

[Aaron Wells (u-aaronw)]

Hi Kristina,

Did you set the institution's "Require license information" setting to "On"? I didn't have any problem selecting "All rights reserved" as the institution or user default license, unless I activated "Require license information".

The reason that setting prevents it, is because we've just renamed "No License" to "All Rights Reserved". So now, "Require license information" means you have to pick a setting other than "All Rights Reserved".

That is a little awkward, but I'm not sure what the best way to fix it would be. If we consider "All Rights Reserved" to *be* a license, then it's no longer possible for a user to avoid selecting a license, because all content gets "All Rights Reserved" by default. Or I suppose we could restore the old "No license" functionality, and add "All Rights Reserved" as a new license, which has to be explicitly chosen.

Thoughts?

Cheers,
Aaron

[Kristina Hoeppner (kris-hoeppner)]

Hi Aaron,

I did have "Require license info" set to "Yes". Since now the "All rights reserved" appears in the list alphabetically, I am expecting to be able to select it. In the past that was not the case because it was "None selected". Maybe the easiest would be to make "Copyright" a regular license and still keep the "None selected" as empty placeholder so as not to assume too much in the way of which license had been chosen.

Cheers
Kristina

[Aaron Wells (u-aaronw)]

I think you're right, making "All rights reserved" and "None selected" into distinct license types is the best way to go. I'll update the patch.

[Kristina Hoeppner (kris-hoeppner)]

"None selected" was changed to "All rights reserved", which fixed the problem.