Google drive folders no longer work in Google Apps block

Bug #1600668 reported by Aaron Wells on 2016-07-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Undecided
Unassigned
15.04
Undecided
Unassigned
15.10
Undecided
Unassigned
16.04
Undecided
Unassigned

Bug Description

Related to Bug 1600665, while testing out all the different Google media in the Google Apps block, I noticed that Google "collections" no longer work.

Based on context, and comments in the code, I assume the "Google collections" referred to in the Mahara manual ( http://manual.mahara.org/en/16.04/blocks/external.html#google-apps ) are actually Google Docs/Drive folders, and *not* Google Plus collections. This was a stumbling block at first, because the Docs/Drive folders are now called folders, rather than collections. And, from the code, it appears we've never supported embedding Google Plus collections.

Anyway, to replicate:

1. Create a Google Drive folder, like so:

1a. Log in to drive.google.com

1b. Click "New" and then "Folder" to create a new folder.

1c. It will now navigate you into the new folder, so in the nav bar underneath the search bar, you should see "My Drive > Untitled folder" or whatever you named your folder.

1d. In that nav bar, click the little triangle next to your folder's name on "My Drive > Untitled folder". This will open up a menu of options. Select "Get shareable link", and you should get a URL like this: https://drive.google.com/open?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA

1e. Alternately, click the little triangle and select "Share", and copy the link there, which will be like this: https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA&usp=sharing

2. Log in to Mahara

3. Put a Google Apps block into a page

4. Paste the link from Google Drive into the block.

Expected result: The block displays a folder icon, which if clicked, is a link to the folder.

Actual result: You see this error message in the block: "Unable to parse embedded code or URL: https://drive.google.com/folderview?id=0BxaMLoyk4oT_N0ZNQWQtYUUyYjA&usp=sharing "

Reviewed: https://reviews.mahara.org/6709
Committed: https://git.mahara.org/mahara/mahara/commit/0e48b3bd6af018b6812f98b98f293596dbb21ae1
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0e48b3bd6af018b6812f98b98f293596dbb21ae1
Author: Aaron Wells <email address hidden>
Date: Mon Jul 11 16:02:53 2016 +1200

Bug 1600668: Support for new Google Drive folders URLs

Change-Id: I71818f1bded211ecae5d16d07fef0a433e095cd4
behatnotneeded: Can't test Google embeds in Behat

Robert Lyon (robertl-9) on 2016-07-11
Changed in mahara:
status: New → Fix Committed
milestone: none → 16.10.0

Reviewed: https://reviews.mahara.org/6710
Committed: https://git.mahara.org/mahara/mahara/commit/784bafb4624f458289d8ccd936c07bdf3a7a7f15
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 784bafb4624f458289d8ccd936c07bdf3a7a7f15
Author: Aaron Wells <email address hidden>
Date: Mon Jul 11 16:02:53 2016 +1200

Bug 1600668: Support for new Google Drive folders URLs

Change-Id: I71818f1bded211ecae5d16d07fef0a433e095cd4
behatnotneeded: Can't test Google embeds in Behat
(cherry picked from commit 0e48b3bd6af018b6812f98b98f293596dbb21ae1)

Reviewed: https://reviews.mahara.org/6711
Committed: https://git.mahara.org/mahara/mahara/commit/6b7af633b5de4a422896f47e2a0d0753f4c878bc
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 6b7af633b5de4a422896f47e2a0d0753f4c878bc
Author: Aaron Wells <email address hidden>
Date: Mon Jul 11 16:02:53 2016 +1200

Bug 1600668: Support for new Google Drive folders URLs

Change-Id: I71818f1bded211ecae5d16d07fef0a433e095cd4
behatnotneeded: Can't test Google embeds in Behat
(cherry picked from commit 0e48b3bd6af018b6812f98b98f293596dbb21ae1)
(cherry picked from commit 784bafb4624f458289d8ccd936c07bdf3a7a7f15)

Reviewed: https://reviews.mahara.org/6712
Committed: https://git.mahara.org/mahara/mahara/commit/34aeb9bd6f2b99f3b5471cf64b2a7bfb2b2ce685
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 34aeb9bd6f2b99f3b5471cf64b2a7bfb2b2ce685
Author: Aaron Wells <email address hidden>
Date: Mon Jul 11 16:02:53 2016 +1200

Bug 1600668: Support for new Google Drive folders URLs

Change-Id: I71818f1bded211ecae5d16d07fef0a433e095cd4
behatnotneeded: Can't test Google embeds in Behat
(cherry picked from commit 0e48b3bd6af018b6812f98b98f293596dbb21ae1)
(cherry picked from commit 784bafb4624f458289d8ccd936c07bdf3a7a7f15)
(cherry picked from commit 6b7af633b5de4a422896f47e2a0d0753f4c878bc)

Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers