Don't print "share page" link when viewing site template pages

Bug #1599373 reported by Aaron Wells on 2016-07-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Unassigned
16.04
Medium
Unassigned
16.10
Medium
Unassigned

Bug Description

Currently when you edit the Profile site template, or the Page site template, you confusingly see a "share page" link on them. This link shouldn't be there, because site template pages aren't meant to be shared and seen by people like normal pages. They're only there to define the default blocks that are present in new pages of their pagetype.

To replicate:

1. Log in to Mahara
2. Go to Administration -> Configure site -> Pages
3. Click the edit link for "Page template"

Expected result: You see the page template in edit mode, but with no "Share page" link
Actual result: You see the page template in edit mode, *with* a "Share page" link

The same happens for the Profile template.

Reviewed: https://reviews.mahara.org/6659
Committed: https://git.mahara.org/mahara/mahara/commit/d6afb35ee970a4db29920e0670360ef4c6e1f946
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d6afb35ee970a4db29920e0670360ef4c6e1f946
Author: Aaron Wells <email address hidden>
Date: Wed Jul 6 18:54:49 2016 +1200

Bug 1599373: Don't print the "share page" or "display page" links for site pages

Since we now have multiple places that check whether the view is a site template
page, I've consolidated the logic for it into View::is_site_template()

Change-Id: Ibf23fe14d7f5bba8e1dc5a1281a2534d32b9887a
behatnotneeded: Test to be provided later

Reviewed: https://reviews.mahara.org/6662
Committed: https://git.mahara.org/mahara/mahara/commit/6f4e874e6435193ef6d758b6acb40f588e996d85
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 6f4e874e6435193ef6d758b6acb40f588e996d85
Author: Aaron Wells <email address hidden>
Date: Wed Jul 6 18:54:49 2016 +1200

Bug 1599373: Don't print the "share page" or "display page" links for site pages

Since we now have multiple places that check whether the view is a site template
page, I've consolidated the logic for it into View::is_site_template()

Change-Id: Ibf23fe14d7f5bba8e1dc5a1281a2534d32b9887a
behatnotneeded: Test to be provided later
(cherry picked from commit d6afb35ee970a4db29920e0670360ef4c6e1f946)

Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
milestone: 16.10.0 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers