Weirdness in edit tabs for site templates
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Aaron Wells | ||
16.04 |
Fix Released
|
Medium
|
Aaron Wells | ||
16.10 |
Fix Released
|
Medium
|
Aaron Wells |
Bug Description
I noticed this irregularity while testing out the patch for Bug 1588606:
1. Go to Administration -> Configure site -> Pages -> Edit group homepage
2. Notice how it has a "Display page" link, and links to the "edit content" screen, the "edit layout" screen, and the "choose skin" screen.
3. Click on the "edit layout" button
4. Notice how the "Edit layout" screen doesn't have a "Display page" link or a link to the "Choose skin" screen.
Expected result: The "Edit content" screen should be limited in the same way as the "Edit layout" screen.
The underlying problem here is that layout.php (which loads up the "Edit Layout" screen) correctly populates the "issitetemplate" smarty variable, but blocks.php (which loads the "Edit content" screen) does not. So although both screens use editviewtabs.tpl, they display it differently.
Changed in mahara: | |
milestone: | 16.10.0 → none |
status: | Fix Committed → Fix Released |
Patch for "master" branch: https:/ /reviews. mahara. org/6568