Weirdness in edit tabs for site templates

Bug #1590300 reported by Aaron Wells on 2016-06-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Aaron Wells
16.04
Medium
Aaron Wells
16.10
Medium
Aaron Wells

Bug Description

I noticed this irregularity while testing out the patch for Bug 1588606:

1. Go to Administration -> Configure site -> Pages -> Edit group homepage

2. Notice how it has a "Display page" link, and links to the "edit content" screen, the "edit layout" screen, and the "choose skin" screen.

3. Click on the "edit layout" button

4. Notice how the "Edit layout" screen doesn't have a "Display page" link or a link to the "Choose skin" screen.

Expected result: The "Edit content" screen should be limited in the same way as the "Edit layout" screen.

The underlying problem here is that layout.php (which loads up the "Edit Layout" screen) correctly populates the "issitetemplate" smarty variable, but blocks.php (which loads the "Edit content" screen) does not. So although both screens use editviewtabs.tpl, they display it differently.

Reviewed: https://reviews.mahara.org/6568
Committed: https://git.mahara.org/mahara/mahara/commit/ac9a33a679ff26621324560984446c86e8a8430a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ac9a33a679ff26621324560984446c86e8a8430a
Author: Aaron Wells <email address hidden>
Date: Wed Jun 8 19:53:07 2016 +1200

Bug 1590300: Typo in smarty variable

Regression from Bug 1397110

Change-Id: I6f98131dd61e06d0bc9d268bbe3eee1c4d4fbcb0
behatnotneeded: covered by existing tests

Reviewed: https://reviews.mahara.org/6569
Committed: https://git.mahara.org/mahara/mahara/commit/af2780deba838e531c1a61318be59b5eb40589e3
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit af2780deba838e531c1a61318be59b5eb40589e3
Author: Aaron Wells <email address hidden>
Date: Wed Jun 8 19:53:07 2016 +1200

Bug 1590300: Typo in smarty variable

Regression from Bug 1397110

Change-Id: I6f98131dd61e06d0bc9d268bbe3eee1c4d4fbcb0
behatnotneeded: covered by existing tests
(cherry picked from commit ac9a33a679ff26621324560984446c86e8a8430a)

Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
milestone: 16.10.0 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers