No indents forum reply fails when the last post has been deleted

Bug #1587474 reported by Lenka on 2016-05-31
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
High
Pramith Dayananda
15.04
High
Unassigned
15.10
High
Unassigned
16.04
High
Unassigned
16.10
High
Pramith Dayananda

Bug Description

When a 'Forum indent mode' is set to 'No indents', the 'Reply' button tries to create a reply to the last post and it fails when the last post has been deleted
(see screenshots attached)

Tested on Mahara 1.10 and 16.04

Probably related to https://bugs.launchpad.net/mahara/+bug/1328388 where the individual reply buttons for posts have been removed.

Lenka (lienkalenka) wrote :
Lenka (lienkalenka) wrote :

Hi Lenka,

Are you guys going to fix that?

Cheers
Kristina

Changed in mahara:
status: New → Confirmed
importance: Undecided → High
Lenka (lienkalenka) wrote :

Hi Kristina,

no, we don't have any developer available right now and have provided a workaround for the client.

Cheers,
Lenka

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/6564

Reviewed: https://reviews.mahara.org/6564
Committed: https://git.mahara.org/mahara/mahara/commit/f9cef9d829887f2fb9a5b6a80b1a6dca689456dd
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit f9cef9d829887f2fb9a5b6a80b1a6dca689456dd
Author: Pramith Dayananda <email address hidden>
Date: Tue Jun 7 16:59:10 2016 +1200

Bug 1587474: No indents forum reply fails when the last post has been deleted

behatnotneeded

Change-Id: I52cdd0199a30b0eaa6c067f079bb043ff92ce885

Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6584

Mahara Bot (dev-mahara) wrote :

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6585

Reviewed: https://reviews.mahara.org/6583
Committed: https://git.mahara.org/mahara/mahara/commit/97b2778e01107dec780158618fc5e742ef830730
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 97b2778e01107dec780158618fc5e742ef830730
Author: Pramith Dayananda <email address hidden>
Date: Tue Jun 7 16:59:10 2016 +1200

Bug 1587474: No indents forum reply fails when the last post has been deleted

behatnotneeded

Change-Id: I52cdd0199a30b0eaa6c067f079bb043ff92ce885
(cherry picked from commit f9cef9d829887f2fb9a5b6a80b1a6dca689456dd)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6585
Committed: https://git.mahara.org/mahara/mahara/commit/5190027bf209a52b169b3decde8e1dcfc48845bc
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 5190027bf209a52b169b3decde8e1dcfc48845bc
Author: Pramith Dayananda <email address hidden>
Date: Tue Jun 7 16:59:10 2016 +1200

Bug 1587474: No indents forum reply fails when the last post has been deleted

behatnotneeded

Change-Id: I52cdd0199a30b0eaa6c067f079bb043ff92ce885
(cherry picked from commit f9cef9d829887f2fb9a5b6a80b1a6dca689456dd)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6584
Committed: https://git.mahara.org/mahara/mahara/commit/5f07178a1a7102f03ab2935ad5c514d4ad3e21da
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 5f07178a1a7102f03ab2935ad5c514d4ad3e21da
Author: Pramith Dayananda <email address hidden>
Date: Tue Jun 7 16:59:10 2016 +1200

Bug 1587474: No indents forum reply fails when the last post has been deleted

behatnotneeded

Change-Id: I52cdd0199a30b0eaa6c067f079bb043ff92ce885
(cherry picked from commit f9cef9d829887f2fb9a5b6a80b1a6dca689456dd)

Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
status: Fix Committed → Fix Released
Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
milestone: 16.10.0 → none
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers