Comment deletion forms & buttons with non-unique IDs

Bug #1582967 reported by Aaron Wells on 2016-05-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Aaron Wells
15.04
Low
Aaron Wells
15.10
Low
Aaron Wells
16.04
Low
Aaron Wells
16.10
Low
Aaron Wells

Bug Description

While working on Bug 1580499, I noticed that the forms and buttons for comment deletion all have the same ID. This specifically gets in the way of me using their IDs for some workarounds in the Behat tests, but also it's just bad HTML. According to the HTML spec, the "ID" attribute is meant to be unique in the whole page.

Aaron Wells (u-aaronw) wrote :

Hm, looks like this has been the case since the "delete comment" button was first added in 2010.

Reviewed: https://reviews.mahara.org/6496
Committed: https://git.mahara.org/mahara/mahara/commit/192bbcbab85bcbfdee7d9cf896d3e27c92c60a4d
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 192bbcbab85bcbfdee7d9cf896d3e27c92c60a4d
Author: Aaron Wells <email address hidden>
Date: Wed May 18 14:40:14 2016 +1200

Bug 1582967: Make "Delete Comment" form IDs unique

Change-Id: I4a217eda8ae6ec9691541cc38c3efd3538aa2c0b
behatnotneeded: Covered by existing tests

Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6507

Mahara Bot (dev-mahara) wrote :

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6508

Reviewed: https://reviews.mahara.org/6506
Committed: https://git.mahara.org/mahara/mahara/commit/647b20e1cdf83b5d20dfed188ace4e71397948b7
Submitter: Son Nguyen (<email address hidden>)
Branch: 15.04_STABLE

commit 647b20e1cdf83b5d20dfed188ace4e71397948b7
Author: Aaron Wells <email address hidden>
Date: Wed May 18 14:40:14 2016 +1200

Bug 1582967: Make "Delete Comment" form IDs unique

Change-Id: I4a217eda8ae6ec9691541cc38c3efd3538aa2c0b
behatnotneeded: Covered by existing tests

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6507
Committed: https://git.mahara.org/mahara/mahara/commit/0dfd7e96b3dd39b8eb989c63116a348a6f6ad60c
Submitter: Son Nguyen (<email address hidden>)
Branch: 15.10_STABLE

commit 0dfd7e96b3dd39b8eb989c63116a348a6f6ad60c
Author: Aaron Wells <email address hidden>
Date: Wed May 18 14:40:14 2016 +1200

Bug 1582967: Make "Delete Comment" form IDs unique

Change-Id: I4a217eda8ae6ec9691541cc38c3efd3538aa2c0b
behatnotneeded: Covered by existing tests

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6508
Committed: https://git.mahara.org/mahara/mahara/commit/ff5b7d8c7802345ab16d1d4e1eb936ef418fda83
Submitter: Son Nguyen (<email address hidden>)
Branch: 16.04_STABLE

commit ff5b7d8c7802345ab16d1d4e1eb936ef418fda83
Author: Aaron Wells <email address hidden>
Date: Wed May 18 14:40:14 2016 +1200

Bug 1582967: Make "Delete Comment" form IDs unique

Change-Id: I4a217eda8ae6ec9691541cc38c3efd3538aa2c0b
behatnotneeded: Covered by existing tests

Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
milestone: 16.10.0 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers