Mahara

Modern theme: disappearing password label

Bug #1579628 reported by Ghada El-Zoghbi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Liam
15.10
Fix Released
High
Unassigned
Mahara 15.10.4
16.04
Fix Released
High
Unassigned
Mahara 16.04.1
16.10
Fix Released
High
Liam
Mahara 16.10.0

Bug Description

Mahara: 16.04
os: Linux
DB: Postgres
Browser: FF, Chrome

When the theme is Modern and the user types in the wrong username / password credentials on the login screen, the label for the password appears as white on white. It looks like the label is no longer there.

Please refer to the attached image.

Tags: front-end
Revision history for this message
Ghada El-Zoghbi (ghada-z) wrote :
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Ghada, are you going to fix this?

tags: added: front-end
removed: theming
Changed in mahara:
status: New → Confirmed
importance: Undecided → High
milestone: none → 16.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6544

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

While the text is now readable in the patch, the outline of the password box is not yet. A very light outline is there once you clicked into the field, but none when it's not clicked yet. This still needs fixing in the patch.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6544
Committed: https://git.mahara.org/mahara/mahara/commit/5709e5507dc0a2d9abffac3febe7075944cf6e48
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5709e5507dc0a2d9abffac3febe7075944cf6e48
Author: Liam Sharpe <email address hidden>
Date: Fri Jun 3 09:51:01 2016 +1200

Bug #1579628: Fixed invisibible password label in theme "Modern"

When a wrong password was entered on the login scrren, the password label
could not be read because it was white on white in the "Modern" theme.

Is a generic issue with Modern theme forms

behatnotneeded

Change-Id: I37c29633b247b60c08760f7c90dc8937f629dd81

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6579

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6580

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6580
Committed: https://git.mahara.org/mahara/mahara/commit/0fea03ade929ba38bb15649209d7ad726a25f8ac
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 0fea03ade929ba38bb15649209d7ad726a25f8ac
Author: Liam Sharpe <email address hidden>
Date: Fri Jun 3 09:51:01 2016 +1200

Bug #1579628: Fixed invisibible password label in theme "Modern"

When a wrong password was entered on the login scrren, the password label
could not be read because it was white on white in the "Modern" theme.

Is a generic issue with Modern theme forms

behatnotneeded

Change-Id: I37c29633b247b60c08760f7c90dc8937f629dd81
(cherry picked from commit 5709e5507dc0a2d9abffac3febe7075944cf6e48)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6579
Committed: https://git.mahara.org/mahara/mahara/commit/52da22d82685aa9742dfb73e9f8a98c16c503a15
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 52da22d82685aa9742dfb73e9f8a98c16c503a15
Author: Liam Sharpe <email address hidden>
Date: Fri Jun 3 09:51:01 2016 +1200

Bug #1579628: Fixed invisibible password label in theme "Modern"

When a wrong password was entered on the login scrren, the password label
could not be read because it was white on white in the "Modern" theme.

Is a generic issue with Modern theme forms

behatnotneeded

Change-Id: I37c29633b247b60c08760f7c90dc8937f629dd81
(cherry picked from commit 5709e5507dc0a2d9abffac3febe7075944cf6e48)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.