Butons "Select all" "Slect none" in OpenBadge displayer are not translated

Bug #1578701 reported by Dominique-Alain JAN on 2016-05-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
16.04
High
Unassigned
16.10
High
Robert Lyon

Bug Description

Although all occurrences of "Select all" and "Select none" are translated into French in the French langpack, they are displayed in English in the OpenBadge Displayer.

I have search in the code of the OB Displayer to find the terms "Select all" without success.

Where is the catch?

-dajan

Robert Lyon (robertl-9) wrote :

The two strings were in the js/configform.js file.

I've added a patch to make them fetch the correct string

Reviewed: https://reviews.mahara.org/6464
Committed: https://git.mahara.org/mahara/mahara/commit/6e14ea43b06f284fac1c568294ece3f727048985
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 6e14ea43b06f284fac1c568294ece3f727048985
Author: Robert Lyon <email address hidden>
Date: Sat May 7 14:46:32 2016 +1200

Bug 1578701: Stringifying hard coded lang strings in openbadges

behatnotneeded

Change-Id: I97c6777b97b13994c15f855be6504918db59bc9c
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/6466
Committed: https://git.mahara.org/mahara/mahara/commit/f9649a54f3be311c451e88b7fbee301b3d8bafcb
Submitter: Son Nguyen (<email address hidden>)
Branch: 16.04_STABLE

commit f9649a54f3be311c451e88b7fbee301b3d8bafcb
Author: Robert Lyon <email address hidden>
Date: Sat May 7 14:46:32 2016 +1200

Bug 1578701: Stringifying hard coded lang strings in openbadges

behatnotneeded

Change-Id: I97c6777b97b13994c15f855be6504918db59bc9c
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6e14ea43b06f284fac1c568294ece3f727048985)

Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
status: Fix Committed → Fix Released
Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
milestone: 16.10.0 → none
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers