PHP7 fixing dwoo dynamic property references

Bug #1577259 reported by Robert Lyon on 2016-05-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
15.04
High
Unassigned
15.10
High
Unassigned
16.04
High
Unassigned
16.10
High
Unassigned

Bug Description

Where dynamic property references have changed in php7 - you need to enclose the variable reference name in {} completely. eg: $data = $data->$m[2][$k] has become $data = $data->{$m[2][$k]}

Reviewed: https://reviews.mahara.org/6455
Committed: https://git.mahara.org/mahara/mahara/commit/92b6e408b9b2aee482c174270823eae34c477a98
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 92b6e408b9b2aee482c174270823eae34c477a98
Author: Piers Harding <email address hidden>
Date: Mon May 2 12:53:08 2016 +1200

Bug 1577259: fix dynamic property references in dwoo for php7

behatnotneeded

Change-Id: Iac965f8ce3999be6ae839a10cf5da7b2fd3b0487
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6481

Mahara Bot (dev-mahara) wrote :

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6482

Reviewed: https://reviews.mahara.org/6482
Committed: https://git.mahara.org/mahara/mahara/commit/3691f6b32cb56a7cd7a99263ed086ffd6afa9cca
Submitter: Son Nguyen (<email address hidden>)
Branch: 15.04_STABLE

commit 3691f6b32cb56a7cd7a99263ed086ffd6afa9cca
Author: Piers Harding <email address hidden>
Date: Mon May 2 12:53:08 2016 +1200

Bug 1577259: fix dynamic property references in dwoo for php7

behatnotneeded

Change-Id: Iac965f8ce3999be6ae839a10cf5da7b2fd3b0487
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 92b6e408b9b2aee482c174270823eae34c477a98)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6481
Committed: https://git.mahara.org/mahara/mahara/commit/6f67a0af3f98fa3cfe3cea6f474712c2d475cd79
Submitter: Son Nguyen (<email address hidden>)
Branch: 15.10_STABLE

commit 6f67a0af3f98fa3cfe3cea6f474712c2d475cd79
Author: Piers Harding <email address hidden>
Date: Mon May 2 12:53:08 2016 +1200

Bug 1577259: fix dynamic property references in dwoo for php7

behatnotneeded

Change-Id: Iac965f8ce3999be6ae839a10cf5da7b2fd3b0487
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 92b6e408b9b2aee482c174270823eae34c477a98)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6480
Committed: https://git.mahara.org/mahara/mahara/commit/65af6c8c4127f0ddf8045b64587fd842b70bea97
Submitter: Son Nguyen (<email address hidden>)
Branch: 16.04_STABLE

commit 65af6c8c4127f0ddf8045b64587fd842b70bea97
Author: Piers Harding <email address hidden>
Date: Mon May 2 12:53:08 2016 +1200

Bug 1577259: fix dynamic property references in dwoo for php7

behatnotneeded

Change-Id: Iac965f8ce3999be6ae839a10cf5da7b2fd3b0487
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 92b6e408b9b2aee482c174270823eae34c477a98)

Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
status: Fix Committed → Fix Released
Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
milestone: 16.10.0 → none
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers