Badly setup authinstance can cause 'This Auth plugin has not been initialised' error

Bug #1570640 reported by Robert Lyon on 2016-04-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
1.10
High
Unassigned
15.04
High
Unassigned
15.10
High
Unassigned
16.04
High
Robert Lyon
16.10
High
Unassigned

Bug Description

If a user types their username in wrong then the system will try and see if other authinstances allow autocreate user.

But if one of those other instances is set up wrong/broken then a fatal error will be thrown, rather than showing the user they got their username/password wrong message

This is a bit harsh, so we should catch this error and add a warning about broken plugin

Robert Lyon (robertl-9) wrote :

The patch related to master: https://reviews.mahara.org/#/c/6339/

Reviewed: https://reviews.mahara.org/6339
Committed: https://git.mahara.org/mahara/mahara/commit/4993ce1c411e51453f01a571952cedd2a5cb1991
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 4993ce1c411e51453f01a571952cedd2a5cb1991
Author: Robert Lyon <email address hidden>
Date: Fri Apr 15 11:06:41 2016 +1200

Bug 1570640: Ignore plugins with bad auth config

When looping through all auth to see if a user can login

behatnotneeded

Change-Id: I51693fac3c650ff529ccfc98586c50f4d185f591
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6381

Mahara Bot (dev-mahara) wrote :

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6382

Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/6383

Reviewed: https://reviews.mahara.org/6383
Committed: https://git.mahara.org/mahara/mahara/commit/4859621df6ee9d4998e16ca1319615d03da0007f
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.10_STABLE

commit 4859621df6ee9d4998e16ca1319615d03da0007f
Author: Robert Lyon <email address hidden>
Date: Fri Apr 15 11:06:41 2016 +1200

Bug 1570640: Ignore plugins with bad auth config

When looping through all auth to see if a user can login

behatnotneeded

Change-Id: I51693fac3c650ff529ccfc98586c50f4d185f591
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4993ce1c411e51453f01a571952cedd2a5cb1991)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6380
Committed: https://git.mahara.org/mahara/mahara/commit/273c80da4c40107d8f9680b3fc735b982d9966ee
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 273c80da4c40107d8f9680b3fc735b982d9966ee
Author: Robert Lyon <email address hidden>
Date: Fri Apr 15 11:06:41 2016 +1200

Bug 1570640: Ignore plugins with bad auth config

When looping through all auth to see if a user can login

behatnotneeded

Change-Id: I51693fac3c650ff529ccfc98586c50f4d185f591
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4993ce1c411e51453f01a571952cedd2a5cb1991)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6381
Committed: https://git.mahara.org/mahara/mahara/commit/612a4fd7d3fedd8ca9a39d9816be23ae19077cfd
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 612a4fd7d3fedd8ca9a39d9816be23ae19077cfd
Author: Robert Lyon <email address hidden>
Date: Fri Apr 15 11:06:41 2016 +1200

Bug 1570640: Ignore plugins with bad auth config

When looping through all auth to see if a user can login

behatnotneeded

Change-Id: I51693fac3c650ff529ccfc98586c50f4d185f591
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4993ce1c411e51453f01a571952cedd2a5cb1991)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6382
Committed: https://git.mahara.org/mahara/mahara/commit/c6723559cfe7cf6988bfa2db22e31f7e30ef8768
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit c6723559cfe7cf6988bfa2db22e31f7e30ef8768
Author: Robert Lyon <email address hidden>
Date: Fri Apr 15 11:06:41 2016 +1200

Bug 1570640: Ignore plugins with bad auth config

When looping through all auth to see if a user can login

behatnotneeded

Change-Id: I51693fac3c650ff529ccfc98586c50f4d185f591
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4993ce1c411e51453f01a571952cedd2a5cb1991)

Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers