Mahara

$user->find_by_username is NOT case insensitive

Bug #1567100 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
Mahara 16.04.0
15.04
Fix Released
High
Unassigned
Mahara 15.04.7
15.10
Fix Released
High
Unassigned
Mahara 15.10.3
16.04
Fix Released
High
Unassigned
Mahara 16.04.0
16.10
Fix Released
High
Unassigned
Mahara 16.10.0

Bug Description

The function find_by_username doesn't use LOWER(username) but the function find_by_instanceid_username() does

We should be consistent and check find_by_username as lowercase as well

See bug 684425 for related info

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6310

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6310
Committed: https://git.mahara.org/mahara/mahara/commit/fb330e38079d589146313bd70f64c4637bf40e48
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit fb330e38079d589146313bd70f64c4637bf40e48
Author: Robert Lyon <email address hidden>
Date: Thu Apr 7 09:58:36 2016 +1200

Bug 1567100: In Mahara we deal with username in a case insensitive way

In other places we check the LOWER(username) but for some reason
in find_by_username() we don't. We should do it here as well for
consistency.

behatnotneeded

Change-Id: Ie692aeace0c8aa2f6989683e094ac6625f153b98
Signed-off-by: Robert Lyon <email address hidden>

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: New → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6392

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6393

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6394

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/6395

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6392
Committed: https://git.mahara.org/mahara/mahara/commit/2d94e3bb695792deb43f0572470b1a0e1f7932db
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 2d94e3bb695792deb43f0572470b1a0e1f7932db
Author: Robert Lyon <email address hidden>
Date: Thu Apr 7 09:58:36 2016 +1200

Bug 1567100: In Mahara we deal with username in a case insensitive way

In other places we check the LOWER(username) but for some reason
in find_by_username() we don't. We should do it here as well for
consistency.

behatnotneeded

Change-Id: Ie692aeace0c8aa2f6989683e094ac6625f153b98
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit fb330e38079d589146313bd70f64c4637bf40e48)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6395
Committed: https://git.mahara.org/mahara/mahara/commit/c144fcfa1cc06a58af44a182a4e6605b96b6b022
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit c144fcfa1cc06a58af44a182a4e6605b96b6b022
Author: Robert Lyon <email address hidden>
Date: Thu Apr 7 09:58:36 2016 +1200

Bug 1567100: In Mahara we deal with username in a case insensitive way

In other places we check the LOWER(username) but for some reason
in find_by_username() we don't. We should do it here as well for
consistency.

behatnotneeded

Change-Id: Ie692aeace0c8aa2f6989683e094ac6625f153b98
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit fb330e38079d589146313bd70f64c4637bf40e48)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6394
Committed: https://git.mahara.org/mahara/mahara/commit/f84b2d8d7e7457d3d891d83c01cfa2aa60bd82fc
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit f84b2d8d7e7457d3d891d83c01cfa2aa60bd82fc
Author: Robert Lyon <email address hidden>
Date: Thu Apr 7 09:58:36 2016 +1200

Bug 1567100: In Mahara we deal with username in a case insensitive way

In other places we check the LOWER(username) but for some reason
in find_by_username() we don't. We should do it here as well for
consistency.

behatnotneeded

Change-Id: Ie692aeace0c8aa2f6989683e094ac6625f153b98
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit fb330e38079d589146313bd70f64c4637bf40e48)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6393
Committed: https://git.mahara.org/mahara/mahara/commit/17211abf6f311f303296ce6d42b9563578c66d56
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 17211abf6f311f303296ce6d42b9563578c66d56
Author: Robert Lyon <email address hidden>
Date: Thu Apr 7 09:58:36 2016 +1200

Bug 1567100: In Mahara we deal with username in a case insensitive way

In other places we check the LOWER(username) but for some reason
in find_by_username() we don't. We should do it here as well for
consistency.

behatnotneeded

Change-Id: Ie692aeace0c8aa2f6989683e094ac6625f153b98
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit fb330e38079d589146313bd70f64c4637bf40e48)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.