Mahara SAML auth broken with Simplesamlphp 1.14.x

[kloostec]

When attempting to use Mahara 15.10.1 on Ubuntu 14.04.4 with Simplesamlphp 1.14.x, I attempt to SSO login and get the error:

PHP Fatal error: Call to undefined method SimpleSAML_Session::getInstance() in /cluster/www/sites/secure.smus.ca/www/mahara/auth/saml/index.php on line 56

This appears to be because the Simplesamlphp people removed the function call SimpleSAML_Session::getInstance() in version 1.14.0:

https://simplesamlphp.org/docs/stable/simplesamlphp-upgrade-notes-1.14

I looked at auth/saml/index.php and it doesn't look like there are too many times that $saml_session is used. I'll see if I can figure out what to use in place of the $saml_session stuff.

[kloostec (kloostec)]

This diff fixed logins and logouts on our server with SimpleSAMLPHP 1.14.2.

It appears that they've taken away the ability to query the SimpleSAML_Session object for many parameters. For example, instead of:

$saml_session->getIdP();

they want you to do:

$as->getAuthData('saml:sp:IdP');

I couldn't figure out a good way to replace ->getAuthority() so I moved the code to figure out which SP to use above the logout functionality and use that instead. This is probably just because I don't work with the SimpleSAMLPHP code enough to understand where that functionality went.

Chris

[Kristina Hoeppner (kris-hoeppner)]

Hi Chris,

Thank you very much for the patch. We'll take a look.

Cheers
Kristina

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/6433

[Aaron Wells (u-aaronw)]

Thanks for the patch, kloostec! I've pushed it into our Gerrit code review system here: https://reviews.mahara.org/6433

Let me know if you'd like me to change the author line. I based it on your Launchpad account.

Cheers,
Aaron

[Mahara Bot (dev-mahara)]

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6719

[Aaron Wells (u-aaronw)]

The first patch for Bug 1579285 wound up re-implementing the same things, so this patch is no longer needed for the master (16.10) branch.

The earlier branches are still affected, which is to say they're incompatible with SimpleSAMLPHP 1.14.x. But I think the code change is not backwards-compatible with older SimpleSAMLPHP versions, so that makes it too risky to include in a minor version release because it might break someone's existing setup.

[kaefert (kaefert)]

I can confirm that the patch works for mahara 15.10.2 with simplesamlphp-1.14.6

[Robert Lyon (robertl-9)]

FYI: The patches listed above have been abandoned