When disabling external resources, local images can not be inserted into Text block

[Son Nguyen]

Version: master (16.04), 15.04, 15.10
Platform: any
Browser: any

Steps

1. Login as a site admin, turn ON "Disable external resources in user HTML' in Administration/Site Configurations/Security Settings
2. Login as a normal user
 - edit a page
 - insert a Text block
 - insert an local image into the text editor (you can see the image in the editor)
 - click Save

Expected result
 You should see the image inside the Text block

Actual
 No image is shown

[Kristina Hoeppner (kris-hoeppner)]

Disabling external resources should not affect the domain on which the Mahara site is hosted.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/6114

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/6115

[Kristina Hoeppner (kris-hoeppner)]

While it's a big issue, it's a non-issue for most people as many will allow external resources. Therefore, fixing it only in master.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/6114
Committed: https://git.mahara.org/mahara/mahara/commit/4f33131feb6d7748bb7d16e37cfcb9b08102a7eb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4f33131feb6d7748bb7d16e37cfcb9b08102a7eb
Author: Son Nguyen <email address hidden>
Date: Tue Mar 8 13:19:43 2016 +1300

Bug 1550519. Add some step definitions for behat tests

- Then I should see images in the block :title
- Then I should not see images in the block :title

Fix the step "I set the field ..." to assign value with double quote

behatnotneeded - the tests are in the child patch

Change-Id: I70a8fcbf46cfbff8db6d2e257b82ef0a10bfeef4

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/6115
Committed: https://git.mahara.org/mahara/mahara/commit/af88973e801a8c051248cd8b0e85afe5af539d69
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit af88973e801a8c051248cd8b0e85afe5af539d69
Author: Son Nguyen <email address hidden>
Date: Mon Mar 7 12:00:54 2016 +1300

Bug 1550519. Fix HTMLPurifier disable external resource setting.

Add behat tests

Change-Id: I905af729d2cda76d5c6ff31b29b9d21c3dc67505