Button border missing when no second button in web services application connections

Bug #1545375 reported by Kristina Hoeppner on 2016-02-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Liam
15.10
Medium
Unassigned
16.04
Medium
Unassigned
16.10
Medium
Liam

Bug Description

Mahara 15.10+

When there is no Delete button available next to the "Generate" button in the web services application connections, the right border on the "Generate" button is missing (see screenshot).

The button should also receive an icon. Since it only generates a token, I think the refresh icon would be good that we use on /admin/site/networking.php

Steps to replicate:

1. Turn on webservices and at least one protocol under "Web services config".
2. Set up web services auth for at least one institution and one user in that institution.
3. Go back to web services config screen /webservice/admin/index.php and go to panel "Manage service access tokens".
4. Search for the user that has web services auth and click the "Generate token" button.
5. Confirm the next page.
6. Go to "Application connections" /webservice/apptokens.php. You should see the user there and only the "Generate" button.

When you click the "Generate" button, a token is generated and the "Delete" button becomes visible. You can go back to just the "Generate" button by clicking the "Delete" button.

Liam (liam-sharpe) wrote :

I have added the icon to the button but I have been unable to add the border so far.

When I add the class 'last' it adds the border on the right but removes the one on the left. And when the second button is there, the buttons no longer connect since they each have their own border and border radius'.

Reviewed: https://reviews.mahara.org/6456
Committed: https://git.mahara.org/mahara/mahara/commit/72f363b110c02a0881e2ccccb18f2e7d8eb82b1f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 72f363b110c02a0881e2ccccb18f2e7d8eb82b1f
Author: Liam Sharpe <email address hidden>
Date: Thu May 5 11:42:24 2016 +1200

Added a icon to the generate button on webservices - Bug #1545375

And allow the generate button to have right side when delete button is
not present

behatnotneeded

Change-Id: Ib1fca4c19b0edcc3e7129601f53169b5a16e0f60

Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6462

Reviewed: https://reviews.mahara.org/6461
Committed: https://git.mahara.org/mahara/mahara/commit/b0764d5f03a51e9a1cbe4662483ebe092e951998
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit b0764d5f03a51e9a1cbe4662483ebe092e951998
Author: Liam Sharpe <email address hidden>
Date: Thu May 5 11:42:24 2016 +1200

Added a icon to the generate button on webservices - Bug #1545375

And allow the generate button to have right side when delete button is
not present

behatnotneeded

Change-Id: Ib1fca4c19b0edcc3e7129601f53169b5a16e0f60

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6462
Committed: https://git.mahara.org/mahara/mahara/commit/ce69a57f4a6719574adae7bd178511c7a3c908e9
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit ce69a57f4a6719574adae7bd178511c7a3c908e9
Author: Liam Sharpe <email address hidden>
Date: Thu May 5 11:42:24 2016 +1200

Added a icon to the generate button on webservices - Bug #1545375

And allow the generate button to have right side when delete button is
not present

behatnotneeded

Change-Id: Ib1fca4c19b0edcc3e7129601f53169b5a16e0f60

Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers