Institution statistics don't show proper names

Bug #1542786 reported by Kristina Hoeppner on 2016-02-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
15.04
High
Unassigned
15.10
High
Unassigned

Bug Description

Mahara 15.10+

The institution statistics for users for an institution do not show the correct data but rather the site URL and only user IDs (see attached).

The information should look something like http://manual.mahara.org/en/15.04/_images/institution_statistics_users.png

The site statistics are displayed correctly.

Robert Lyon (robertl-9) on 2016-02-11
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Robert Lyon (robertl-9)
tags: added: usermanualupdate
Aaron Wells (u-aaronw) wrote :

This regression bug was introduced in patch https://reviews.mahara.org/#/c/3389/, which updated some of the stats lang strings to be properly pluralizable (on the "Has X friends" part of the string).

The problem was that when writing & code-reviewing the patch, we didn't search the code base to make sure that it modified *every* place in the code where the strings were used.

Reviewed: https://reviews.mahara.org/6049
Committed: https://git.mahara.org/mahara/mahara/commit/2b74dec001c62b5a9928df24b7bc51b958add2db
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 2b74dec001c62b5a9928df24b7bc51b958add2db
Author: Robert Lyon <email address hidden>
Date: Thu Feb 11 13:39:47 2016 +1300

Bug 1542786: Correctly applying args to strings for statistics

For the instition statistics users tab

Also fixing up the display of size in bytes, added round() to output
as it's not useful to show anything less than whole bytes

behatnotneeded

Change-Id: I13a842c910463660299b2b92d5319a03eacb2cab
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Mahara Bot (dev-mahara) wrote :

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6149

Reviewed: https://reviews.mahara.org/6148
Committed: https://git.mahara.org/mahara/mahara/commit/ddff1b6ba5a327d0debe0d14658dc2e88aa2483f
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit ddff1b6ba5a327d0debe0d14658dc2e88aa2483f
Author: Robert Lyon <email address hidden>
Date: Thu Feb 11 13:39:47 2016 +1300

Bug 1542786: Correctly applying args to strings for statistics

For the instition statistics users tab

Also fixing up the display of size in bytes, added round() to output
as it's not useful to show anything less than whole bytes

behatnotneeded

Change-Id: I13a842c910463660299b2b92d5319a03eacb2cab
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 2b74dec001c62b5a9928df24b7bc51b958add2db)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6149
Committed: https://git.mahara.org/mahara/mahara/commit/61926ed8bd9097317cf49556534fdb963c82d748
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 61926ed8bd9097317cf49556534fdb963c82d748
Author: Robert Lyon <email address hidden>
Date: Thu Feb 11 13:39:47 2016 +1300

Bug 1542786: Correctly applying args to strings for statistics

For the instition statistics users tab

Also fixing up the display of size in bytes, added round() to output
as it's not useful to show anything less than whole bytes

behatnotneeded

Change-Id: I13a842c910463660299b2b92d5319a03eacb2cab
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 2b74dec001c62b5a9928df24b7bc51b958add2db)

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers