Remove obsolete Pear plugins library

Bug #1535989 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon

Bug Description

Keeping plugins up to date.

I note there is a xmlparser.php included in this - maybe we don't need the other xmlparser anymore?

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5946

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/5947

Changed in mahara:
status: New → In Progress
Revision history for this message
Robert Lyon (robertl-9) wrote : Re: Upgrade Pear plugin to 1.10.1

We probably should look for a better non PEAR option for the libraries that rely on PEAR, eg Pear/XML, PEAR/Archive, PEAR/Log

Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 16.04.0 → 16.10.0
Revision history for this message
Robert Lyon (robertl-9) wrote :

Sonn,
Hmm, I thought I'd written up my findings somewhere but I can seem to find it now.

But the gist of what I was thinking is this:

1) For dropping PEAR/XML, which looks to be used for the xml_feed_parser on RSS feeds, we could try using PHP in-built XML_Parser / XMLREADER or similar

2) For dropping PEAR/Archive/Tar we could just make an executive decision and drop the ability to extract .tar/.tar.gz archives in the Files page, as I suspect very few people use this functionality.

As most systems now have some in-built form of zip/unzip available we could just alert them with a message saying if they want to extract the files from the archive they will need to add it as a valid .zip format. Or not even bother and just have some mention of it in the Mahara manual.

3) For dropping PEAR/Log - not sure for this but it would be good to find out what it is logging and why that is different to error_log/log_debug. It might be simply we can use one of those to achieve the same result.

Robert

Revision history for this message
Son Nguyen (ngson2000) wrote :

1) I will use PHP XML library (http://www.php.net/xml) to replace the PEAR::XML_Feed_Parser
I created a new bug for this https://bugs.launchpad.net/mahara/+bug/1594615

Revision history for this message
Son Nguyen (ngson2000) wrote :

PEAR/Log is only used in FeedReader and Tar. We can remove it after replacing 1 and 2

Revision history for this message
Robert Lyon (robertl-9) wrote :

Now that we have updated the xml parser and archive extraction to non Pear libraries we can remove the /lib/pear/ directory

summary: - Upgrade Pear plugin to 1.10.1
+ Remove obsolete Pear plugins library
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7108

Revision history for this message
Robert Lyon (robertl-9) wrote :

See bug 1594615 and bug 1602452 for the replacements for the pear functions

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7108
Committed: https://git.mahara.org/mahara/mahara/commit/e40e39437644e6169a6480bc9fb48feb8dca6ece
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit e40e39437644e6169a6480bc9fb48feb8dca6ece
Author: Robert Lyon <email address hidden>
Date: Mon Oct 10 13:45:29 2016 +1300

Bug 1535989: Remove the PEAR libraries

Now that we are using modern equivalents

behatnotneeded - should be fine using existing tests

Change-Id: If5d7a13dea5e6240a36740d12fc74cc9e3e304d4
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7169

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7169
Committed: https://git.mahara.org/mahara/mahara/commit/4e990401bb606d03bc58cc475e41060f730d9adf
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 4e990401bb606d03bc58cc475e41060f730d9adf
Author: Robert Lyon <email address hidden>
Date: Mon Oct 10 13:45:29 2016 +1300

Bug 1535989: Remove the PEAR libraries

Now that we are using modern equivalents

behatnotneeded - should be fine using existing tests

Change-Id: If5d7a13dea5e6240a36740d12fc74cc9e3e304d4
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit e40e39437644e6169a6480bc9fb48feb8dca6ece)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.0 → 16.10.1
Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Released
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.1 → 16.10.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.