Upgrade Select2 plugin to 4.0.1

Bug #1533971 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon

Bug Description

Due to bug 1530613 we need to use the new syntax for custom selection template.

But Select2 v4.0.0 templateSelection function only passes the item value and not container object.

This has been fixed in 4.0.1 https://github.com/select2/select2/releases/tag/4.0.1 so we need to upgrade Mahara to use 4.0.1 to allow the fixing of bug 1530613.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5914

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5914
Committed: https://git.mahara.org/mahara/mahara/commit/7348878122587bb3f29975458c59f47d7b6ed2d5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7348878122587bb3f29975458c59f47d7b6ed2d5
Author: Robert Lyon <email address hidden>
Date: Fri Jan 15 12:41:20 2016 +1300

Bug 1533971: Adding v4.0.1

behatnotneeded external library

Change-Id: I0f05181347916a328758e180efe0a2254b5b6c57
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6183

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6183
Committed: https://git.mahara.org/mahara/mahara/commit/cf08dc6365ef9a3b0abfe7631d328ab41fe3cef3
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit cf08dc6365ef9a3b0abfe7631d328ab41fe3cef3
Author: Robert Lyon <email address hidden>
Date: Fri Jan 15 12:41:20 2016 +1300

Bug 1533971: Adding v4.0.1

behatnotneeded external library

Change-Id: I0f05181347916a328758e180efe0a2254b5b6c57
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.