Remove old thumb.png files
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Low
|
Aaron Wells |
Bug Description
In 15.10 we switched to using fontawesome icons to display the icons for blocktypes. Prior to that, we relied on a file called "thumb.png" under each blocktype's image directory (or under the corresponding directory in the theme).
Through an oversight, we left these images in place in Mahara 15.10. In 15.10.0 they were basically useless. In 15.10.1, after the patch for Bug 1510421, they become potentially useful because we began providing both the FontAwesome icon name *and* the thumb.png path to view/blocktypel
However, since we're no longer using these icons in the core themes, they are likely to fall out of support, so we should probably just delete theme from core.
If we do this:
1. Third-party plugins can still provide a thumb.png file (for backwards-
2. Third-party theme developers can still provide their own thumb.png files for the core blocktypes if they wish. They'll just need to place them under their own theme directory (i.e. /theme/
So it won't have any effect on what third-party devs can do. It'll just remove some unused and unmaintained image files from the core Mahara distribution.
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Probably shouldn't backport this, because it's sort of a feature change.
For testing, just make sure that the icons for all the core blocktype plugins still display properly in the block picker. (i.e., create a new page, and look through the list of blocks you can add to the page)